Follow-up from "Fix N+1 Issue with loading approval rules"
The following discussion from !52364 (merged) should be addressed:
-
@mkaeppler started a discussion: (+2 comments) There is something odd going on here that I think we should look at: previously, this was mutating
super
, sincepush
is a side-effecting method. Now we concatenate two arrays, which creates a copy of whatsuper
returns.Perhaps this is the desired behavior, but it makes this case switch difficult to reason about, since some cases mutate state, while others return new values.
Can we think of a way to consolidate this?