Follow-up from "Add route for threat monitoring alert details"
The following discussion from !51417 (merged) should be addressed:
-
@aturinske started a discussion: (+2 comments) @brytannia this test keeps returning a 200, but I am not sure I am testing an empty
id
properly, can you give this a look? If I omitid
from above, it errors withno route matches this request
instead of saying the test passes with:not_found
.🤔
Implementation plan
-
Add validation for alert id in the controller -
Add specs for both invalid and non-existing alert id
Edited by Zamir Martins