Follow-up from "Protected branches log audits events"
The following discussion from !16399 (merged) should be addressed:
-
@splattael started a discussion: (+4 comments) I've noticed that we are logging despite the original creation was successful or not - we are not dealing with errors there. Is this intended? Should we still log if creating a protected branch fails?
This is probably out of scope of this MR but should we make sure that creating/updating and destroying protected branches are successful and deal with failures? Maybe we could utilize
ServiceResponse
as service results?🤔