Design for "Merge requests that require my attention"
Problem to solve
Currently the MR dropdown provides incredible value for users to notice when they have pending reviews.
However, some customer/user workflows keep the Reviewers assigned through the several iterations of code review.
This leads to other behaviours like assigning reviewers as Assignees as well.
If we distinguish the MR in which the user is a Reviewer but that have the review marked as completed (by submitting a MR review or in any other way), we allow the reviewer to focus only on the ones that are currently in their court, awaiting their review.
Intended users
User experience goal
Users should be able to notice MRs are waiting for their action (as an assignee or reviewer) and also call for someone else to act on the MR.
Proposal
See a more complete explanation of the proposal in #321045 (comment 520201220)
- Add a new
Waiting-For=@username
filter to the MR lists — see explanation - Change the MR item in the top bar to:
- Show the count of MRs that are in the
Waiting-For=me
list. - Have links to
Waiting for you
,All assigned to you
, andAll reviews for you
.
- Show the count of MRs that are in the
- Add the ability for Reviewers to “wait for the assignee,” using a button in the sidebar similar to the
Re-request review
button. - Add status indicators next to the assignee and reviewer avatars, both in the MR lists and in the MR sidebar:
- Clock icon:
Waiting for assignee
- Circle icon:
Review requested
- Checkmark icon:
Approved
- Clock icon:
- Instrument the dropdown links, and the
Re-request review
andWait for assignee
buttons
MR sidebar | MR dropdown | MR list |
---|---|---|
![]() |
For the dropdown we can have something like: MERGE REQUESTS |
![]() |