Custom metrics UI shows 404 when no license
Summary
(Summarize the bug encountered concisely)
The custom metrics UI shows a 404 not found message when the user does not have the custom metrics license available (Premium/Silver plans onwards have custom metrics).
Steps to reproduce
(How one can reproduce the issue - this is very important)
- Remove any Premium/Silver license that your project has.
- If the project is on gitlab.com, make it private because public projects get Gold features for free.
- Go to Settings > Integrations > Prometheus.
- There will be a 404 message in the Custom Metrics section.
Example Project
(If possible, please create an example project here on GitLab.com that exhibits the problematic behavior, and link to it here in the bug report)
(If you are using an older version of GitLab, this will also determine whether the bug is fixed in a more recent version)
What is the current bug behavior?
(What actually happens)
A 404 message is displayed when license does not allow the Custom Metrics feature.
What is the expected correct behavior?
(What you should see instead)
Not sure what should be displayed.
Maybe we can hide the entire Custom Metrics section? Or display a message saying that Custom Metrics is not available on the current license.
Relevant logs and/or screenshots
(Paste any relevant logs - please use code blocks (```) to format console output, logs, and code as it's tough to read otherwise.)
Output of checks
(If you are reporting a bug on GitLab.com, write: This bug happens on GitLab.com)
Results of GitLab environment info
Expand for output related to GitLab environment info
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:env:info
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production
)
Results of GitLab application Check
Expand for output related to the GitLab application check
(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true
)(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true
)(we will only investigate if the tests are passing)
Possible fixes
(If you can, link to the line of code that might be responsible for the problem)