Embed specific metrics chart in issue - follow-up
Summary
https://gitlab.com/gitlab-org/gitlab-ce/issues/62971 adds support for embedding a particular metric panel in any markdown field. There are a few follow-up items that came out of that.
-
refactor
CustomMetricEmbedService
to use a newPrometheusMetricFinder
class
Designs
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Sarah Yasonik changed milestone to %12.3
changed milestone to %12.3
- Sarah Yasonik added Health backend devopsmonitor grouprespond + 1 deleted label
added Health backend devopsmonitor grouprespond + 1 deleted label
- Sarah Yasonik changed the description
changed the description
- Sarah Yasonik added workflowin dev label
added workflowin dev label
- Sarah Yasonik added workflowin review label and removed workflowin dev label
added workflowin review label and removed workflowin dev label
- Sarah Yasonik added workflowin dev label and removed workflowin review label
added workflowin dev label and removed workflowin review label
- 🤖 GitLab Bot 🤖 changed milestone to %12.3
changed milestone to %12.3
- Seth Engelhard removed 1 deleted label
removed 1 deleted label
- Contributor
@sarahwaldner I'm moving this to %12.4
@syasonik can you verify the state of this issue? Is this something that is currently in development?
Collapse replies - Author Developer
I have an MR up to address some tech debt incurred during implementation of embedding specific metrics. I need to address some feedback on it, but I've been prioritizing deliverables over this item, which is why it's milestone-hopped a bit. The ~"workflow::In dev" label is accurate.
- Contributor
Excellent- thank you for the context!
- Seth Engelhard changed milestone to %12.4
changed milestone to %12.4
- Sarah Yasonik changed the description
changed the description
- Author Developer
Backend Async Update 1 week, 4 days to cutoff Summary of current status? Stalled while my focus is on #31376 (closed), but it shouldn't take long to fix up once I prioritize it. ETA on maintainer review? Probably during 12.5... Can we break it down more? Nope. cc @sengelhard
1 - Contributor
Moving to %12.5 due reflect reality
2 - Seth Engelhard changed milestone to %12.5
changed milestone to %12.5
- Seth Engelhard added Deliverable label
added Deliverable label
- Sarah Yasonik added workflowin review label and removed workflowin dev label
added workflowin review label and removed workflowin dev label
- Author Developer
Backend Async Update Summary of current status? Through a couple rounds of great review. ETA on maintainer review? Monday. Can we break it down more? Nope. Edited by Sarah Yasonik - 🤖 GitLab Bot 🤖 added missed:12.5 label
added missed:12.5 label
- 🤖 GitLab Bot 🤖 added missed-deliverable label
added missed-deliverable label
- Sarah Yasonik marked the checklist item refactor
CustomMetricEmbedService
to use a newPrometheusMetricFinder
class as completedmarked the checklist item refactor
CustomMetricEmbedService
to use a newPrometheusMetricFinder
class as completed - Sarah Yasonik removed missed-deliverable missed:12.5 labels
removed missed-deliverable missed:12.5 labels
- Author Developer
Refactor was merged in 12.5 - !16235 (merged). Closing.
- Sarah Yasonik closed
closed