GitHub Import: Missing pull request merged by

Summary

Currently the Github Importer is not importing the merged by field of the merged pull requests.

Steps to reproduce

1. Create a pull request in GitHub
2. Merge the pull request
3. Import project to GitLab
4. Navigate to closed Merge requests, the merged by will be emtpy

What is the current bug behavior?

The Merged by is a blank user.

What is the expected correct behavior?

When the merged by user can be mapped on Gitlab, this field should be filled. Otherwise a comment should be added like: Merged by "user".

Relevant logs and/or screenshots

GitLab screenshot showing the missing Merge Request approver and comment

NB: hovering over the Merged by icon doesn't show anything either.

GitHub Pull Request screenshot showing the approver and approval comment

Related

https://gitlab.com/gitlab-org/gitlab-ce/issues/58158

Results of GitLab environment info

Expand for output related to GitLab environment info

$ sudo gitlab-rake gitlab:env:info
System information
System:		Ubuntu 16.04
Proxy:		no
Current User:	git
Using RVM:	no
Ruby Version:	2.6.3p62
Gem Version:	2.7.9
Bundler Version:1.17.3
Rake Version:	12.3.2
Redis Version:	3.2.12
Git Version:	2.21.0
Sidekiq Version:5.2.7
Go Version:	unknown
GitLab information
Version:	12.0.3-ee
Revision:	1b1872f9d93
Directory:	/opt/gitlab/embedded/service/gitlab-rails
DB Adapter:	PostgreSQL
DB Version:	10.7
URL:		
HTTP Clone URL:	/some-group/some-project.git
SSH Clone URL:	:some-group/some-project.git
Elasticsearch:	no
Geo:		no
Using LDAP:	no
Using Omniauth:	yes
Omniauth Providers: saml, bitbucket, github
GitLab Shell
Version:	9.3.0
Repository storage paths:

• default: /var/opt/gitlab/git-data/repositories GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell Git: /opt/gitlab/embedded/bin/git

Results of GitLab application Check

Expand for output related to the GitLab application check

$ sudo gitlab-rake gitlab:check SANITIZE=true
Checking GitLab subtasks ...
Checking GitLab Shell ...
GitLab Shell: ... GitLab Shell version >= 9.3.0 ? ... OK (9.3.0)
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Check GitLab API access: OK
Redis available via internal API: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK
gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Gitaly ...
Gitaly: ... default ... OK
Checking Gitaly ... Finished
Checking Sidekiq ...
Sidekiq: ... Running? ... yes
Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Incoming Email ...
Incoming Email: ... Checking Reply by email ...
IMAP server credentials are correct? ... yes
Init.d configured correctly? ... skipped
MailRoom running? ... skipped
Checking Reply by email ... Finished
Checking Incoming Email ... Finished
Checking LDAP ...
LDAP: ... LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab App ...
Git configured correctly? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... yes
Uploads directory tmp has correct permissions? ... yes
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
Projects have namespace: ...
2/2 ... yes
2/3 ... yes
2/4 ... yes
2/5 ... yes
7/6 ... yes
2/7 ... yes
7/8 ... yes
9/9 ... yes
7/10 ... yes
10/11 ... yes
7/12 ... yes
9/13 ... yes
7/14 ... yes
9/15 ... yes
2/16 ... yes
17/23 ... yes
120/26 ... yes
17/27 ... yes
7/28 ... yes
10/32 ... yes
10/33 ... yes
10/34 ... yes
10/35 ... yes
10/36 ... yes
10/37 ... yes
10/38 ... yes
10/39 ... yes
31/40 ... yes
9/42 ... yes
10/43 ... yes
10/44 ... yes
10/45 ... yes
17/46 ... yes
9/47 ... yes
2/48 ... yes
10/50 ... yes
10/51 ... yes
10/52 ... yes
10/53 ... yes
10/54 ... yes
9/55 ... yes
10/56 ... yes
10/57 ... yes
10/58 ... yes
10/59 ... yes
10/60 ... yes
10/61 ... yes
34/62 ... yes
34/63 ... yes
34/64 ... yes
34/65 ... yes
10/67 ... yes
17/68 ... yes
17/69 ... yes
17/70 ... yes
17/71 ... yes
31/72 ... yes
9/73 ... yes
13/74 ... yes
31/75 ... yes
2/76 ... yes
39/90 ... yes
39/91 ... yes
39/92 ... yes
39/93 ... yes
39/95 ... yes
39/97 ... yes
39/98 ... yes
17/99 ... yes
41/103 ... yes
41/104 ... yes
41/105 ... yes
41/106 ... yes
41/107 ... yes
41/108 ... yes
41/109 ... yes
41/110 ... yes
41/112 ... yes
41/113 ... yes
41/114 ... yes
41/115 ... yes
41/116 ... yes
41/117 ... yes
41/118 ... yes
41/119 ... yes
41/120 ... yes
41/121 ... yes
41/122 ... yes
41/124 ... yes
41/125 ... yes
41/126 ... yes
41/127 ... yes
41/128 ... yes
41/129 ... yes
41/130 ... yes
41/131 ... yes
41/132 ... yes
41/133 ... yes
41/135 ... yes
41/136 ... yes
41/137 ... yes
41/138 ... yes
41/139 ... yes
39/140 ... yes
57/141 ... yes
41/142 ... yes
9/143 ... yes
9/144 ... yes
9/146 ... yes
39/147 ... yes
31/148 ... yes
10/150 ... yes
59/153 ... yes
59/154 ... yes
59/155 ... yes
10/156 ... yes
10/157 ... yes
10/158 ... yes
9/159 ... yes
34/160 ... yes
31/161 ... yes
41/162 ... yes
10/163 ... yes
60/164 ... yes
57/165 ... yes
34/166 ... yes
62/167 ... yes
62/168 ... yes
62/169 ... yes
9/170 ... yes
61/173 ... yes
64/175 ... yes
57/176 ... yes
57/177 ... yes
57/178 ... yes
57/179 ... yes
57/180 ... yes
57/181 ... yes
57/182 ... yes
73/183 ... yes
10/184 ... yes
13/185 ... yes
39/186 ... yes
64/187 ... yes
31/188 ... yes
74/189 ... yes
57/190 ... yes
64/191 ... yes
107/192 ... yes
9/193 ... yes
57/194 ... yes
60/195 ... yes
121/196 ... yes
57/199 ... yes
2/200 ... yes
10/201 ... yes
17/202 ... yes
39/203 ... yes
2/204 ... yes
9/205 ... yes
10/206 ... yes
32/208 ... yes
64/209 ... yes
9/210 ... yes
7/212 ... yes
41/213 ... yes
39/214 ... yes
34/216 ... yes
2/217 ... yes
41/218 ... yes
84/219 ... yes
2/220 ... yes
9/221 ... yes
31/222 ... yes
64/224 ... yes
77/225 ... yes
77/226 ... yes
77/227 ... yes
57/228 ... yes
57/229 ... yes
73/230 ... yes
41/231 ... yes
88/232 ... yes
41/233 ... yes
41/234 ... yes
57/235 ... yes
10/236 ... yes
88/237 ... yes
120/238 ... yes
57/239 ... yes
30/240 ... yes
74/241 ... yes
3/242 ... yes
64/243 ... yes
31/244 ... yes
10/245 ... yes
64/246 ... yes
17/247 ... yes
40/248 ... yes
39/249 ... yes
64/250 ... yes
2/251 ... yes
13/252 ... yes
119/253 ... yes
57/254 ... yes
9/255 ... yes
74/256 ... yes
57/257 ... yes
10/258 ... yes
10/259 ... yes
2/260 ... yes
10/261 ... yes
39/262 ... yes
60/263 ... yes
9/264 ... yes
99/265 ... yes
9/266 ... yes
7/267 ... yes
15/268 ... yes
2/269 ... yes
88/270 ... yes
41/271 ... yes
41/272 ... yes
9/273 ... yes
10/274 ... yes
73/275 ... yes
103/276 ... yes
103/277 ... yes
2/278 ... yes
10/279 ... yes
88/280 ... yes
31/281 ... yes
88/282 ... yes
105/283 ... yes
105/284 ... yes
105/285 ... yes
105/286 ... yes
105/287 ... yes
105/288 ... yes
105/289 ... yes
105/290 ... yes
105/291 ... yes
105/292 ... yes
64/293 ... yes
41/294 ... yes
9/295 ... yes
108/296 ... yes
88/297 ... yes
43/298 ... yes
43/299 ... yes
43/300 ... yes
41/301 ... yes
41/302 ... yes
41/303 ... yes
41/304 ... yes
41/305 ... yes
41/306 ... yes
41/307 ... yes
41/308 ... yes
41/309 ... yes
41/310 ... yes
41/311 ... yes
2/312 ... yes
41/313 ... yes
41/314 ... yes
39/315 ... yes
39/316 ... yes
39/317 ... yes
39/318 ... yes
39/319 ... yes
40/321 ... yes
39/322 ... yes
39/323 ... yes
17/324 ... yes
110/325 ... yes
41/326 ... yes
41/327 ... yes
39/328 ... yes
9/329 ... yes
39/330 ... yes
111/332 ... yes
41/333 ... yes
88/334 ... yes
73/335 ... yes
110/337 ... yes
39/339 ... yes
39/340 ... yes
39/341 ... yes
57/342 ... yes
39/343 ... yes
39/344 ... yes
115/345 ... yes
115/346 ... yes
2/347 ... yes
115/348 ... yes
10/349 ... yes
115/350 ... yes
10/351 ... yes
2/352 ... yes
41/353 ... yes
41/354 ... yes
88/355 ... yes
115/356 ... yes
2/357 ... yes
47/358 ... yes
7/359 ... yes
115/360 ... yes
119/361 ... yes
10/363 ... yes
31/364 ... yes
74/365 ... yes
88/366 ... yes
118/367 ... yes
39/368 ... yes
2/369 ... yes
39/370 ... yes
121/371 ... yes
121/372 ... yes
121/373 ... yes
39/374 ... yes
41/375 ... yes
110/376 ... yes
41/377 ... yes
39/378 ... yes
88/379 ... yes
39/380 ... yes
17/381 ... yes
34/383 ... yes
2/384 ... yes
84/386 ... yes
84/387 ... yes
115/388 ... yes
115/389 ... yes
39/390 ... yes
2/391 ... yes
57/392 ... yes
41/394 ... yes
2/395 ... yes
125/397 ... yes
57/398 ... yes
39/399 ... yes
39/400 ... yes
141/401 ... yes
125/402 ... yes
39/403 ... yes
9/404 ... yes
39/406 ... yes
142/407 ... yes
73/408 ... yes
41/409 ... yes
41/410 ... yes
88/411 ... yes
147/412 ... yes
147/413 ... yes
143/414 ... yes
96/415 ... yes
128/416 ... yes
53/419 ... yes
147/420 ... yes
9/421 ... yes
13/422 ... yes
150/423 ... yes
39/424 ... yes
118/425 ... yes
10/426 ... yes
41/427 ... yes
41/428 ... yes
41/429 ... yes
41/430 ... yes
31/431 ... yes
9/432 ... yes
10/433 ... yes
13/434 ... yes
110/435 ... yes
39/441 ... yes
150/443 ... yes
18/447 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.5.3 ? ... yes (2.6.3)
Git version >= 2.21.0 ? ... yes (2.21.0)
Git user has default SSH configuration? ... yes
Active users: ... 91
Elasticsearch version 5.6 - 6.x? ... skipped (elasticsearch is disabled)
Checking GitLab App ... Finished
Checking GitLab subtasks ... Finished

Documentation

The following doc page should be updated after this feature is implemented: https://docs.gitlab.com/ee/user/project/import/github.html