Skip to content

GitHub Import: Line specific MR comments on discussion tab are empty

Summary

On GitHub import, any comments/reviews on a PR on specific lines are displayed as empty on the Discussion tab on the MR. They are correctly shown on Changes tab.

Steps to reproduce

  1. Create a new project by importing from GitHub.
  2. Use the personal access token in 1Password for gitlab-qa GitHub user to list GitHub repositories.
  3. Import the test-project
  4. After the import, navigate to MRs of the imported project.

Note that the discussions are empty.

Example Project

On Gitlab.com, I am not able to import the project and getting this on the UI:

An error occurred while importing project: Error: Request failed with status code 422

(This could be a separate bug on GitLab.com)

What is the current bug behavior?

Line specific comments/reviews on a PR are empty on the Discussion tab.

What is the expected correct behavior?

The discussions should have the correct text.

Relevant logs and/or screenshots

Empty discussions:

Screenshot_2019-02-25_18.12.28

This is from the github repo at https://github.com/gitlab-qa/test-project/pull/2:

Screenshot_2019-02-25_18.11.41

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info 
System information
System:
Current User:	sanadliaquat
Using RVM:	yes
RVM Version:	1.29.7
Ruby Version:	2.5.3p105
Gem Version:	2.7.8
Bundler Version:1.16.6
Rake Version:	12.3.2
Redis Version:	5.0.3
Git Version:	2.20.1
Sidekiq Version:5.2.5
Go Version:	go1.11.4 darwin/amd64

GitLab information
Version:	11.9.0-pre
Revision:	e8d23f62fff
Directory:	/Users/sanadliaquat/work/gitlab/gdk-ce/gitlab
DB Adapter:	postgresql
URL:		http://localhost:3000
HTTP Clone URL:	http://localhost:3000/some-group/some-project.git
SSH Clone URL:	ssh://sanadliaquat@localhost:2222/some-group/some-project.git
Using LDAP:	no
Using Omniauth:	yes
Omniauth Providers: github


GitLab Shell
Version:	8.6.0
Repository storage paths:
  • default: /Users/sanadliaquat/work/gitlab/gdk-ce/repositories Hooks: /Users/sanadliaquat/work/gitlab/gdk-ce/gitlab-shell/hooks Git: /usr/local/bin/git
Edited by Sanad Liaquat