Skip to content
GitLab
Next
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 44,767
    • Issues 44,767
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1,332
    • Merge requests 1,332
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLabGitLab
  • Issues
  • #299850
You need to sign in or sign up before continuing.
Closed
Open
Issue created Jan 25, 2021 by Thong Kuah@tkuah5️⃣Maintainer5 of 5 checklist items completed5/5 checklist items

Add gitlab_kas enabled and KAS address in config/gitlab.yml

We should have a place where the instance admin can configure whether :

  1. GitLab KAS is enabled, or not.
  2. GitLab KAS's external URL for connecting agents.
  3. GitLab KAS's internal API URL, for calling KAS from the GitLab backend
  4. (Nice to have) The KAS server version, if different from GITLAB_KAS_VERSION

This is will be similar to GitLab container registry's configuration in config/gitlab.yml.

Release notes

While GitLab administrators could install the Kubernetes Agent Server beside their GitLab instances, until now they lacked much configuration options. The current release offers GitLab Administrators the possibility to specify the Agent Server's external and internal URLs and its enabled status in the core GitLab configuration file, and GitLab will use these configuration values for every interaction with the Agent Server.

Problem

A GitLab instance doesn't know how to show the url for agents to connect. Also GitLab doesn't know if Kas is enabled or not, so it cannot show appropriate messages

Proposal

Add optional keys under gitlab_kas: in config/gitlab.yml

gitlab_kas:
  # enabled: true
  # external_url: wss://kas.gitlab.example.com
  # internal_url: wss://kas.internal

and in follow ups, do:

  1. (Follow up) show the kas url in instructions on how to connect agents.
  2. (Follow up) Have text saying "kas is disabled, and please ask administrator to enable Kas" if Kas is disabled, and there are agent records.

Progress:

  • Add support in gitlab backend: !54260 (merged)
  • Add support for these new keys in GDK: gitlab-development-kit!1842 (merged)
  • Add support for these new keys in Omnibus: omnibus-gitlab!5016 (merged)
  • Add support for these new keys in Chart: gitlab-org/charts/gitlab!1879 (merged)
  • Follow ups created: gitlab-com/gl-infra/delivery#1623 (closed)
Edited Mar 15, 2021 by Hordur Freyr Yngvason
Assignee
Assign to
Time tracking