Product discovery for adding already merged commits to merge request reviews
Follow on from https://gitlab.com/gitlab-org/gitlab-ce/issues/60918
Problem to solve
Code review should not be limited to only changed lines in changed files, because the context of those change lines is important. The context includes unchanged lines in unchanged files, and previous commits that have already merged that the change is built on. A reviewer should be able to bring these changes into attention of other reviewers and the author of the merge request.
The most valuable code reviews are performed by people who are attentive to the broader context and impact of changes, and the reviewers who perform these high quality reviews should be supported with tools that reduce the barrier to leaving these kinds of reviews.
Proposal
In the previous product discovery issue https://gitlab.com/gitlab-org/gitlab-ce/issues/60918 we determined the preferred first iteration was to support adding already merged commits to a merge request so that they can be reviewed.
Mockup add commit | Mockup search commits | Mockup switching commits/comparison |
---|---|---|
Further details from the approach need to be resolved.