Ask admins to confirm auto approval of pending users when settings are updated
Description
There are two admin settings that, when changed to certain values, can auto-approve the users in the Pending approval queue. This changing of settings may have the unintended consequence of adding more users than the admin is willing to have/pay for.
Those settings are:
We should have a modal informing admins that saving the settings will approve all users in the pending approval queue.
| Proposed modal | |
|---|---|
![]() |
Proposed flow
- Admin increases/removes the
User capsetting or disables theRequire admin approvalcheckbox - Admin clicks save changes
- Admin sees the modal (regardless of whether or not there are users in the pending approval status)
- Admin clicks
Approve users- Settings changes are saved
- All users in the pending approval status are approved
Implementation tips
This is not a Vue place so we will most likely need some interaction HAML / Vue. We have some examples in the codebase of it when asking confirmation before deleting a group memeber).
Details
This is a follow-up proposal from #273258 (comment 453885739) where we introduced the auto approval of users in blocked_pending_approval status.
Edited by Andrei Stoicescu


