Moving issues into projects in subgroups will remove assigned group milestones (closed)

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

Summary

Moving an issue from one private project to another project nested in a private subgroup will removed an assigned group milestone.

Steps to reproduce

  • create a private group g1
  • create a private project p1 in group g1
  • create a private subgroup s1 in g1
  • create a private project p2 in g1/s1
  • create a group milestone m1 in group g1
  • create an issue test in project g1/p1
    • assign the group milestone m1
  • move the created issue test into project g1/s1/p2

Example Project

I created a publicly available group (https://gitlab.com/sh-issue-test3) for reproduction.

I created a sample on gitlab (https://gitlab.com/sh-issue-test2), but due to it's private nature, i don't know if you can actually access it.

What is the current bug behavior?

  • the milestone m1 is not assigned anymore to the moved issue

What is the expected correct behavior?

  • the milestone m1 should still be assigned to the moved issue

Relevant logs and/or screenshots

  • this happens on a CE installation, and also on gitlab.com
  • this only seems to happen with private groups/subgroups/projects
    • on gitlab.com i'm unable to reproduce it with public groups/subgroups/projects
  • i haven't checked internal access and in what combinations, but within my setup at work it's basically all private
  • it works when i move issues to projects within the same private group

Output of checks

This bug happens on GitLab.com

Results of GitLab environment info

System information
System:		Ubuntu 16.04
Current User:	git
Using RVM:	no
Ruby Version:	2.5.3p105
Gem Version:	2.7.6
Bundler Version:1.16.6
Rake Version:	12.3.2
Redis Version:	3.2.12
Git Version:	2.18.1
Sidekiq Version:5.2.5
Go Version:	unknown

GitLab information
Version:	11.9.0
Revision:	a47124c
Directory:	/opt/gitlab/embedded/service/gitlab-rails
DB Adapter:	postgresql
URL:		http://aagit01.as-i.com
HTTP Clone URL:	http://aagit01.as-i.com/some-group/some-project.git
SSH Clone URL:	git@aagit01.as-i.com:some-group/some-project.git
Using LDAP:	no
Using Omniauth:	yes
Omniauth Providers: 

GitLab Shell
Version:	8.7.1
Repository storage paths:
- default: 	/var/opt/gitlab/git-data/repositories
GitLab Shell path:		/opt/gitlab/embedded/service/gitlab-shell
Git:		/opt/gitlab/embedded/bin/git

Results of GitLab application Check

Click to expand 
Checking GitLab subtasks ...

Checking GitLab Shell ...

GitLab Shell: ... GitLab Shell version >= 8.7.1 ? ... OK (8.7.1)
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Check GitLab API access: OK
Redis available via internal API: OK

Access to /var/opt/gitlab/.ssh/authorized_keys: OK
gitlab-shell self-check successful

Checking GitLab Shell ... Finished

Checking Gitaly ...

Gitaly: ... default ... OK

Checking Gitaly ... Finished

Checking Sidekiq ...

Sidekiq: ... Running? ... yes
Number of Sidekiq processes ... 1

Checking Sidekiq ... Finished

Checking Incoming Email ...

Incoming Email: ... Reply by email is disabled in config/gitlab.yml

Checking Incoming Email ... Finished

Checking LDAP ...

LDAP: ... LDAP is disabled in config/gitlab.yml

Checking LDAP ... Finished

Checking GitLab App ...

Git configured correctly? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... yes
Uploads directory tmp has correct permissions? ... yes
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
Projects have namespace: ... 
27/1 ... yes
27/6 ... yes
27/7 ... yes
27/8 ... yes
2/9 ... yes
27/10 ... yes
2/11 ... yes
2/12 ... yes
10/13 ... yes
10/29 ... yes
10/30 ... yes
10/31 ... yes
27/33 ... yes
27/34 ... yes
27/38 ... yes
27/41 ... yes
27/42 ... yes
27/45 ... yes
27/49 ... yes
27/51 ... yes
27/52 ... yes
31/53 ... yes
31/55 ... yes
31/56 ... yes
27/57 ... yes
27/58 ... yes
23/60 ... yes
31/61 ... yes
23/62 ... yes
23/63 ... yes
23/64 ... yes
23/65 ... yes
23/66 ... yes
23/67 ... yes
23/68 ... yes
23/69 ... yes
23/70 ... yes
25/71 ... yes
25/72 ... yes
25/73 ... yes
25/74 ... yes
25/75 ... yes
25/77 ... yes
25/78 ... yes
25/79 ... yes
25/80 ... yes
25/81 ... yes
25/82 ... yes
26/83 ... yes
26/84 ... yes
27/87 ... yes
27/88 ... yes
27/89 ... yes
27/90 ... yes
27/91 ... yes
27/92 ... yes
27/93 ... yes
27/94 ... yes
27/96 ... yes
27/97 ... yes
27/98 ... yes
27/99 ... yes
27/100 ... yes
27/101 ... yes
27/102 ... yes
27/103 ... yes
27/104 ... yes
50/106 ... yes
27/107 ... yes
31/108 ... yes
27/109 ... yes
27/110 ... yes
2/111 ... yes
2/112 ... yes
50/113 ... yes
50/114 ... yes
50/115 ... yes
50/116 ... yes
50/117 ... yes
50/118 ... yes
27/119 ... yes
53/120 ... yes
53/121 ... yes
27/122 ... yes
27/123 ... yes
27/124 ... yes
27/130 ... yes
27/131 ... yes
27/132 ... yes
7/133 ... yes
27/134 ... yes
27/135 ... yes
27/136 ... yes
27/137 ... yes
27/138 ... yes
27/139 ... yes
27/140 ... yes
2/142 ... yes
2/143 ... yes
2/144 ... yes
2/145 ... yes
27/146 ... yes
27/147 ... yes
27/148 ... yes
27/149 ... yes
27/150 ... yes
27/151 ... yes
27/152 ... yes
27/153 ... yes
27/154 ... yes
27/155 ... yes
27/156 ... yes
2/157 ... yes
58/158 ... yes
58/159 ... yes
58/160 ... yes
58/161 ... yes
58/162 ... yes
27/163 ... yes
27/164 ... yes
58/165 ... yes
58/168 ... yes
27/169 ... yes
58/170 ... yes
27/171 ... yes
58/172 ... yes
58/173 ... yes
58/174 ... yes
58/175 ... yes
58/176 ... yes
58/177 ... yes
58/179 ... yes
58/180 ... yes
58/181 ... yes
58/182 ... yes
27/183 ... yes
27/184 ... yes
58/185 ... yes
58/186 ... yes
27/187 ... yes
31/188 ... yes
58/189 ... yes
27/190 ... yes
27/191 ... yes
58/192 ... yes
58/193 ... yes
27/194 ... yes
27/195 ... yes
27/196 ... yes
27/197 ... yes
27/198 ... yes
27/199 ... yes
27/200 ... yes
27/201 ... yes
27/202 ... yes
27/203 ... yes
27/204 ... yes
27/205 ... yes
27/206 ... yes
27/207 ... yes
27/208 ... yes
27/209 ... yes
27/210 ... yes
27/211 ... yes
58/212 ... yes
27/213 ... yes
49/214 ... yes
2/215 ... yes
27/216 ... yes
27/217 ... yes
27/218 ... yes
27/219 ... yes
27/220 ... yes
2/221 ... yes
2/222 ... yes
27/223 ... yes
27/224 ... yes
27/225 ... yes
27/226 ... yes
58/227 ... yes
58/228 ... yes
27/229 ... yes
27/230 ... yes
27/231 ... yes
52/232 ... yes
2/233 ... yes
49/234 ... yes
49/235 ... yes
49/237 ... yes
27/238 ... yes
67/239 ... yes
67/240 ... yes
67/241 ... yes
51/242 ... yes
67/243 ... yes
67/244 ... yes
67/245 ... yes
67/246 ... yes
2/247 ... yes
67/248 ... yes
67/249 ... yes
67/250 ... yes
67/251 ... yes
67/252 ... yes
67/253 ... yes
69/254 ... yes
69/255 ... yes
69/256 ... yes
69/257 ... yes
69/258 ... yes
69/259 ... yes
69/260 ... yes
69/261 ... yes
69/262 ... yes
69/263 ... yes
69/264 ... yes
67/265 ... yes
67/266 ... yes
67/267 ... yes
67/268 ... yes
67/269 ... yes
67/270 ... yes
67/271 ... yes
67/272 ... yes
67/273 ... yes
67/274 ... yes
67/275 ... yes
67/276 ... yes
67/277 ... yes
67/278 ... yes
67/279 ... yes
67/280 ... yes
67/281 ... yes
67/282 ... yes
67/283 ... yes
67/284 ... yes
67/285 ... yes
67/286 ... yes
67/287 ... yes
67/288 ... yes
67/289 ... yes
67/290 ... yes
67/291 ... yes
67/292 ... yes
67/293 ... yes
67/294 ... yes
67/295 ... yes
67/296 ... yes
67/297 ... yes
67/298 ... yes
67/299 ... yes
67/300 ... yes
67/301 ... yes
67/302 ... yes
67/303 ... yes
67/304 ... yes
67/305 ... yes
60/306 ... yes
58/307 ... yes
67/308 ... yes
67/309 ... yes
58/310 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.3.5 ? ... yes (2.5.3)
Git version >= 2.18.0 ? ... yes (2.18.1)
Git user has default SSH configuration? ... yes
Active users: ... 21

Checking GitLab App ... Finished


Checking GitLab subtasks ... Finished

Possible fixes

Implementation plan

see thread bellow #27631 (comment 2517979584)

Edited by Alexandru Croitor