Extract Product Analytics metrics aggregation out of HLLRedisCounter module
Summary
!46146 (merged) add new feature that allow for calculation of ~"product analytics(telemetry)" metrics intersections. Due to already existing API of HLLRedisCounter
module, logics of new feature needed access to private methods of this module. Since refactoring HLLRedisCounter
module was out of the scope of !46146 (merged) and also would highly increase number of changes in that MR, it will be better to handle refactoring as a follow up issue, where efforts and attention will be focused solely on that purpose.
Improvements
- Extract shared behavior that allows for basic operations over Redis HLL counters data into separate module that can be included into multiple classes, alternatively abstract parent class can be created that will implement this basic logic.
- Extract logic that calculates aggregated metrics data out of
HLLRedisCounter
module, into new class
Risks
Usage Ping Redis HLL counters may stop working, which can lead to missing parts of usage ping payload, or at worst whole usage ping payloads
Involved components
-
HLLRedisCounter
module