Merge request changes are being rendered incorrect in Chrome v54.0.2840.59
Summary
We just upgraded to Gitlab CE v11.8.1 from v11.3 and now diffs are not rendering correctly in Chrome When reviewing merge request diffs the header above each file is showing up over the diff and often blocks the different code. If I open the diff using the Web-IDE none of the diffs are highlighted. See the screen shots below for examples.
Steps to reproduce
I'm using Chrome Version 54.0.2840.59 (64-bit) on a Ubuntu 16.04 system.
What is the current bug behavior?
In a merge request diff view I'm seeing this:
or in the Web-IDE I see this:
What is the expected correct behavior?
For the merge request diff I expect to see this:
Or for the Web-IDE view I expect to see this:
Relevant logs and/or screenshots
(Paste any relevant logs - please use code blocks (```) to format console output, logs, and code as it's very hard to read otherwise.)
Output of checks
(If you are reporting a bug on GitLab.com, write: This bug happens on GitLab.com)
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Ubuntu 16.04 Current User: git Using RVM: no Ruby Version: 2.5.3p105 Gem Version: 2.7.6 Bundler Version:1.16.6 Rake Version: 12.3.2 Redis Version: 3.2.12 Git Version: 2.18.1 Sidekiq Version:5.2.5 Go Version: unknown GitLab information Version: 11.8.1 Revision: 657d508 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql URL: http://GITLAB.planar.net HTTP Clone URL: http://GITLAB.planar.net/some-group/some-project.git SSH Clone URL: git@GITLAB.planar.net:some-group/some-project.git Using LDAP: yes Using Omniauth: yes Omniauth Providers: GitLab Shell Version: 8.4.4 Repository storage paths: - default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
``` Checking GitLab subtasks ...Checking GitLab Shell ...
GitLab Shell: ... GitLab Shell version >= 8.4.4 ? ... OK (8.4.4) Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Redis available via internal API: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Gitaly ...
Gitaly: ... default ... OK
Checking Gitaly ... Finished
Checking Sidekiq ...
Sidekiq: ... Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Incoming Email ...
Incoming Email: ... Checking Reply by email ...
IMAP server credentials are correct? ... yes Init.d configured correctly? ... skipped MailRoom running? ... skipped
Checking Reply by email ... Finished
Checking Incoming Email ... Finished
Checking LDAP ...
LDAP: ... Server: ldapmain LDAP authentication... Success LDAP users with access to your GitLab server (only showing the first 100 results) DN: cn=0001-ord,ou=computers,ou=ord,ou=domain members,dc=planar,dc=net sAMAccountName: 0001-ORD$ DN: cn=0002-ord,ou=computers,ou=ord,ou=domain members,dc=planar,dc=net sAMAccountName: 0002-ORD$ DN: cn=0003-ord,ou=computers,ou=ord,ou=domain members,dc=planar,dc=net sAMAccountName: 0003-ORD$ DN: cn=0004-ord,ou=computers,ou=ord,ou=domain members,dc=planar,dc=net sAMAccountName: 0004-ORD$ DN: cn=0006-ord,ou=computers,ou=ord,ou=domain members,dc=planar,dc=net sAMAccountName: 0006-ORD$ DN: cn=0007-ord,ou=computers,ou=ord,ou=domain members,dc=planar,dc=net sAMAccountName: 0007-ORD$ DN: cn=0042-eye,ou=computers,ou=ger,ou=domain members,dc=planar,dc=net sAMAccountName: 0042-EYE$ DN: cn=0051-eye,ou=computers,ou=ger,ou=domain members,dc=planar,dc=net sAMAccountName: 0051-EYE$ DN: cn=0061-eye,ou=computers,ou=ger,ou=domain members,dc=planar,dc=net sAMAccountName: 0061-EYE$ DN: cn=0071-eye,ou=computers,ou=ger,ou=domain members,dc=planar,dc=net sAMAccountName: 0071-EYE$ DN: cn=0085-ord,ou=computers,ou=ord,ou=domain members,dc=planar,dc=net sAMAccountName: 0085-ORD$ DN: cn=0087-jwang,ou=computers,ou=ord,ou=domain members,dc=planar,dc=net sAMAccountName: 0087-JWANG$ DN: cn=0088-ord,ou=computers,ou=ord,ou=domain members,dc=planar,dc=net sAMAccountName: 0088-ORD$ DN: cn=0089-ord,ou=computers,ou=ord,ou=domain members,dc=planar,dc=net sAMAccountName: 0089-ORD$ DN: cn=0121-ord,ou=computers,ou=ord,ou=domain members,dc=planar,dc=net sAMAccountName: 0121-ORD$ DN: cn=1195serverroom,ou=it machines,ou=computers,ou=bvt,ou=domain members,dc=planar,dc=net sAMAccountName: 1195SERVERROOM$ DN: cn=2ring,ou=users,ou=bvt,ou=domain members,dc=planar,dc=net sAMAccountName: 2ring DN: cn=30606-evg,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 30606-EVG$ DN: cn=30622-bvt,ou=bvt computers,ou=computers,ou=bvt,ou=domain members,dc=planar,dc=net sAMAccountName: 30622-BVT$ DN: cn=30623-bvt,ou=bvt computers,ou=computers,ou=bvt,ou=domain members,dc=planar,dc=net sAMAccountName: 30623-BVT$ DN: cn=30624-bvt,ou=bvt computers,ou=computers,ou=bvt,ou=domain members,dc=planar,dc=net sAMAccountName: 30624-BVT$ DN: cn=30633-bvt,ou=bvt computers,ou=computers,ou=bvt,ou=domain members,dc=planar,dc=net sAMAccountName: 30633-BVT$ DN: cn=30637-bvt,ou=bvt computers,ou=computers,ou=bvt,ou=domain members,dc=planar,dc=net sAMAccountName: 30637-BVT$ DN: cn=30691-bvt,ou=bvt computers,ou=computers,ou=bvt,ou=domain members,dc=planar,dc=net sAMAccountName: 30691-BVT$ DN: cn=31047-bvt,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31047-BVT$ DN: cn=31050-bvt,ou=bvt computers,ou=computers,ou=bvt,ou=domain members,dc=planar,dc=net sAMAccountName: 31050-BVT$ DN: cn=31150-bvt,ou=bvt computers,ou=computers,ou=bvt,ou=domain members,dc=planar,dc=net sAMAccountName: 31150-BVT$ DN: cn=31198-bvt,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31198-BVT$ DN: cn=31204-bvt,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31204-BVT$ DN: cn=31216-bvt,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31216-BVT$ DN: cn=31227-bvt,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31227-BVT$ DN: cn=31240-bvt,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31240-BVT$ DN: cn=31341-bvt,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31341-BVT$ DN: cn=31342-evg,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31342-EVG$ DN: cn=31349-evg,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31349-EVG$ DN: cn=31359-evg,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31359-EVG$ DN: cn=31371-evg,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31371-EVG$ DN: cn=31395-bvt,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31395-BVT$ DN: cn=31419-bvt,ou=bvt computers,ou=computers,ou=bvt,ou=domain members,dc=planar,dc=net sAMAccountName: 31419-BVT$ DN: cn=31432-evg,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31432-EVG$ DN: cn=31435-bvt,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31435-BVT$ DN: cn=31436-bvt,ou=bvt computers,ou=computers,ou=bvt,ou=domain members,dc=planar,dc=net sAMAccountName: 31436-BVT$ DN: cn=31442-evg,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31442-EVG$ DN: cn=31472-bvt,ou=bvt computers,ou=computers,ou=bvt,ou=domain members,dc=planar,dc=net sAMAccountName: 31472-BVT$ DN: cn=31484-bvt,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31484-BVT$ DN: cn=31507-bvt,ou=bvt computers,ou=computers,ou=bvt,ou=domain members,dc=planar,dc=net sAMAccountName: 31507-BVT$ DN: cn=31510-bvt,ou=bvt computers,ou=computers,ou=bvt,ou=domain members,dc=planar,dc=net sAMAccountName: 31510-BVT$ DN: cn=31517-alb,ou=computers,ou=alb,ou=domain members,dc=planar,dc=net sAMAccountName: 31517-ALB$ DN: cn=31518-alb,ou=computers,ou=alb,ou=domain members,dc=planar,dc=net sAMAccountName: 31518-ALB$ DN: cn=31534-bvt,ou=bvt computers,ou=computers,ou=bvt,ou=domain members,dc=planar,dc=net sAMAccountName: 31534-BVT$ DN: cn=31595-evg,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31595-EVG$ DN: cn=31605-evg,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31605-EVG$ DN: cn=31607-bvt,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31607-BVT$ DN: cn=31608-evg,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31608-EVG$ DN: cn=31610-bvt,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31610-BVT$ DN: cn=31613-evg,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31613-EVG$ DN: cn=31614-evg,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31614-EVG$ DN: cn=31619-evg,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31619-EVG$ DN: cn=31622-evg,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31622-EVG$ DN: cn=31623-evg,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31623-EVG$ DN: cn=31628-evg,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31628-EVG$ DN: cn=31633-evg,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31633-EVG$ DN: cn=31641-evg,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31641-EVG$ DN: cn=31646-bvt,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31646-BVT$ DN: cn=31650-bvt,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31650-BVT$ DN: cn=31658-evg,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31658-EVG$ DN: cn=31661-bvt,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31661-BVT$ DN: cn=31669-bvt,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31669-BVT$ DN: cn=31670-bvt,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31670-BVT$ DN: cn=31672-evg,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31672-EVG$ DN: cn=31682-bvt,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31682-BVT$ DN: cn=31693-evg,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31693-EVG$ DN: cn=31695-evg,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31695-EVG$ DN: cn=31698-bvt,ou=bvt computers,ou=computers,ou=bvt,ou=domain members,dc=planar,dc=net sAMAccountName: 31698-BVT$ DN: cn=31733-bvt,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31733-BVT$ DN: cn=31752-bvt,ou=bvt computers,ou=computers,ou=bvt,ou=domain members,dc=planar,dc=net sAMAccountName: 31752-BVT$ DN: cn=31755-bvt,ou=bvt computers,ou=computers,ou=bvt,ou=domain members,dc=planar,dc=net sAMAccountName: 31755-BVT$ DN: cn=31772-bvt,ou=bvt computers,ou=computers,ou=bvt,ou=domain members,dc=planar,dc=net sAMAccountName: 31772-BVT$ DN: cn=31783-bvt,ou=bvt computers,ou=computers,ou=bvt,ou=domain members,dc=planar,dc=net sAMAccountName: 31783-BVT$ DN: cn=31797-bvt,ou=bvt computers,ou=computers,ou=bvt,ou=domain members,dc=planar,dc=net sAMAccountName: 31797-BVT$ DN: cn=31799-bvt,ou=bvt computers,ou=computers,ou=bvt,ou=domain members,dc=planar,dc=net sAMAccountName: 31799-BVT$ DN: cn=31800-bvt,ou=bvt computers,ou=computers,ou=bvt,ou=domain members,dc=planar,dc=net sAMAccountName: 31800-BVT$ DN: cn=31801-bvt,ou=bvt computers,ou=computers,ou=bvt,ou=domain members,dc=planar,dc=net sAMAccountName: 31801-BVT$ DN: cn=31803-bvt,ou=it machines,ou=computers,ou=bvt,ou=domain members,dc=planar,dc=net sAMAccountName: 31803-BVT$ DN: cn=31804-evg,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31804-EVG$ DN: cn=31806-bvt,ou=bvt computers,ou=computers,ou=bvt,ou=domain members,dc=planar,dc=net sAMAccountName: 31806-BVT$ DN: cn=31813-bvt,ou=bvt computers,ou=computers,ou=bvt,ou=domain members,dc=planar,dc=net sAMAccountName: 31813-BVT$ DN: cn=31816-bvt,ou=bvt computers,ou=computers,ou=bvt,ou=domain members,dc=planar,dc=net sAMAccountName: 31816-BVT$ DN: cn=31817-evg,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31817-EVG$ DN: cn=31818-bvt,ou=bvt computers,ou=computers,ou=bvt,ou=domain members,dc=planar,dc=net sAMAccountName: 31818-BVT$ DN: cn=31819-bvt,ou=bvt computers,ou=computers,ou=bvt,ou=domain members,dc=planar,dc=net sAMAccountName: 31819-BVT$ DN: cn=31821-evg,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31821-EVG$ DN: cn=31823-evg,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31823-EVG$ DN: cn=31824-evg,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31824-EVG$ DN: cn=31825-evg,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31825-EVG$ DN: cn=31827-alb,ou=computers,ou=alb,ou=domain members,dc=planar,dc=net sAMAccountName: 31827-ALB$ DN: cn=31829-bvt,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31829-BVT$ DN: cn=31833-evg,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31833-EVG$ DN: cn=31834-evg,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31834-EVG$ DN: cn=31836-evg,ou=computers,ou=evg,ou=domain members,dc=planar,dc=net sAMAccountName: 31836-EVG$
Checking LDAP ... Finished
Checking GitLab App ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 4/1 ... yes 5/3 ... yes 4/73 ... yes 38/75 ... yes 39/76 ... yes 38/77 ... yes 39/79 ... yes 44/80 ... yes 44/81 ... yes 43/82 ... yes 4/83 ... yes 39/84 ... yes 44/86 ... yes 44/87 ... yes 44/88 ... yes 44/89 ... yes 44/90 ... yes 44/91 ... yes 40/92 ... yes 44/94 ... yes 43/95 ... yes 4/96 ... yes 4/97 ... yes 39/98 ... yes 50/99 ... yes 39/100 ... yes 43/101 ... yes 39/102 ... yes 53/103 ... yes 39/104 ... yes 39/105 ... yes 43/106 ... yes 43/107 ... yes 43/108 ... yes 39/109 ... yes 4/110 ... yes 43/111 ... yes 4/112 ... yes 44/117 ... yes 53/118 ... yes 39/119 ... yes 53/120 ... yes 43/121 ... yes 48/122 ... yes 43/123 ... yes 76/124 ... yes 43/125 ... yes 59/126 ... yes 59/127 ... yes 75/128 ... yes 53/129 ... yes 53/130 ... yes 62/131 ... yes 67/132 ... yes 39/133 ... yes 63/135 ... yes 39/136 ... yes 63/138 ... yes 53/139 ... yes 67/141 ... yes 44/142 ... yes 67/143 ... yes 44/144 ... yes 65/145 ... yes 65/146 ... yes 65/147 ... yes 63/148 ... yes 53/149 ... yes 66/150 ... yes 64/151 ... yes 53/152 ... yes 48/153 ... yes 53/154 ... yes 67/155 ... yes 67/156 ... yes 53/157 ... yes 67/158 ... yes 53/159 ... yes 44/161 ... yes 70/166 ... yes 70/167 ... yes 70/168 ... yes 70/169 ... yes 72/171 ... yes 96/172 ... yes 96/173 ... yes 96/174 ... yes 53/175 ... yes 96/176 ... yes 96/177 ... yes 95/178 ... yes 96/179 ... yes 96/180 ... yes 96/181 ... yes 96/183 ... yes 96/184 ... yes 96/187 ... yes 71/191 ... yes 63/192 ... yes 65/193 ... yes 70/195 ... yes 70/196 ... yes 67/197 ... yes 67/198 ... yes 53/199 ... yes 44/200 ... yes 63/201 ... yes 67/202 ... yes 4/203 ... yes 39/205 ... yes 67/206 ... yes 48/207 ... yes 72/208 ... yes 53/210 ... yes 53/211 ... yes 96/212 ... yes 63/213 ... yes 63/215 ... yes 67/216 ... yes 97/217 ... yes 53/218 ... yes 60/219 ... yes 67/220 ... yes 67/221 ... yes 53/222 ... yes 63/223 ... yes 63/224 ... yes 75/226 ... yes 97/227 ... yes 67/228 ... yes 73/229 ... yes 73/230 ... yes 73/231 ... yes 73/232 ... yes 76/233 ... yes 75/234 ... yes 75/235 ... yes 46/236 ... yes 46/237 ... yes 96/238 ... yes 67/239 ... yes 53/240 ... yes 67/241 ... yes 75/242 ... yes 76/243 ... yes 67/244 ... yes 67/245 ... yes 75/246 ... yes 76/248 ... yes 96/249 ... yes 67/250 ... yes 67/251 ... yes 50/252 ... yes 4/253 ... yes 73/254 ... yes 67/255 ... yes 67/256 ... yes 73/257 ... yes 96/258 ... yes 51/261 ... yes 67/262 ... yes 79/264 ... yes 96/265 ... yes 96/266 ... yes 96/268 ... yes 5/270 ... yes 67/271 ... yes 67/272 ... yes 96/273 ... yes 5/274 ... yes 50/275 ... yes 84/276 ... yes 68/277 ... yes 85/278 ... yes 85/279 ... yes 72/280 ... yes 67/281 ... yes 67/282 ... yes 95/283 ... yes 51/284 ... yes 96/285 ... yes 63/286 ... yes 96/287 ... yes 95/288 ... yes 98/289 ... yes 85/290 ... yes 86/292 ... yes 63/293 ... yes 72/294 ... yes 5/296 ... yes 95/297 ... yes 95/298 ... yes 69/299 ... yes 63/300 ... yes 63/301 ... yes 95/302 ... yes 63/303 ... yes 67/304 ... yes 4/305 ... yes 4/306 ... yes 61/309 ... yes 65/310 ... yes 98/311 ... yes 65/312 ... yes 63/313 ... yes 63/314 ... yes 63/315 ... yes 63/316 ... yes 51/317 ... yes 95/318 ... yes 63/319 ... yes 67/320 ... yes 92/321 ... yes 72/323 ... yes 90/324 ... yes 72/325 ... yes 72/326 ... yes 65/327 ... yes 63/328 ... yes 63/329 ... yes 63/330 ... yes 102/331 ... yes 102/332 ... yes 63/333 ... yes 67/334 ... yes 68/335 ... yes 68/336 ... yes 63/337 ... yes 96/338 ... yes 106/339 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.3.5 ? ... yes (2.5.3) Git version >= 2.18.0 ? ... yes (2.18.1) Git user has default SSH configuration? ... yes Active users: ... 40
Checking GitLab App ... Finished
Checking GitLab subtasks ... Finished
</pre> </details> ### Possible fixes The diffs are rendering correctly in Firefox.