Skip to content

Clean up calls to GraphQL::ID_TYPE

As a follow-up to !44831 (merged) we need to clean up our usages of GraphQL::ID_TYPE and replace them with specific GlobalIDTypes instead.

Please see !44073 (merged) for the intended way to fix these files.

Please note that arguments that end in *_path are exempt from this Cop.

The following files in .rubocop_todo.yml should be dealt with:

  • ee/app/graphql/ee/mutations/issues/update.rb @acroitor
  • ee/app/graphql/ee/types/boards/board_issue_input_base_type.rb @jprovaznik
  • ee/app/graphql/mutations/boards/lists/update_limit_metrics.rb @mdelaossa (taking over for @pd-gitlab who's gone)
  • ee/app/graphql/mutations/instance_security_dashboard/remove_project.rb @mparuszewski
  • ee/app/graphql/mutations/issues/set_epic.rb @egrieff
  • ee/app/graphql/mutations/issues/set_iteration.rb @mdelaossa
  • ee/app/graphql/mutations/iterations/update.rb @digitalmoksha
  • ee/app/graphql/resolvers/iterations_resolver.rb @digitalmoksha
  • app/graphql/mutations/boards/create.rb @egrieff (taking over for @jarka who's OOO)
  • app/graphql/mutations/boards/issues/issue_move_list.rb @egrieff
  • app/graphql/mutations/boards/lists/update.rb @egrieff
  • app/graphql/mutations/discussions/toggle_resolve.rb @.luke
  • app/graphql/mutations/issues/update.rb @acroitor see #268042 (comment 438976365)
  • app/graphql/mutations/merge_requests/set_milestone.rb @mdelaossa
  • app/graphql/mutations/metrics/dashboard/annotations/delete.rb @shreyasagarwal
  • app/graphql/mutations/notes/create/note.rb @.luke
  • app/graphql/mutations/notes/update/base.rb @.luke
  • app/graphql/mutations/snippets/destroy.rb @fjsanpedro
  • app/graphql/mutations/snippets/mark_as_spam.rb @fjsanpedro
  • app/graphql/mutations/snippets/update.rb @fjsanpedro
  • app/graphql/mutations/todos/mark_done.rb @mdelaossa (taking over for @pd-gitlab who's gone)
  • app/graphql/mutations/todos/restore.rb @mdelaossa (taking over for @pd-gitlab who's gone)
  • app/graphql/resolvers/board_lists_resolver.rb @egrieff
  • app/graphql/resolvers/board_resolver.rb @mdelaossa
  • app/graphql/resolvers/boards_resolver.rb @digitalmoksha
  • app/graphql/resolvers/design_management/design_at_version_resolver.rb @alexkalderimis
  • app/graphql/resolvers/design_management/design_resolver.rb @alexkalderimis
  • app/graphql/resolvers/design_management/designs_resolver.rb @alexkalderimis
  • app/graphql/resolvers/design_management/version/design_at_version_resolver.rb @alexkalderimis
  • app/graphql/resolvers/design_management/version_in_collection_resolver.rb @alexkalderimis
  • app/graphql/resolvers/design_management/version_resolver.rb @alexkalderimis
  • app/graphql/resolvers/design_management/versions_resolver.rb @alexkalderimis
  • app/graphql/resolvers/error_tracking/sentry_detailed_error_resolver.rb @seanarnold
  • app/graphql/resolvers/error_tracking/sentry_error_stack_trace_resolver.rb @seanarnold
  • app/graphql/resolvers/snippets_resolver.rb @fjsanpedro
  • app/graphql/resolvers/user_merge_requests_resolver.rb @alexkalderimis
  • app/graphql/resolvers/user_resolver.rb @mwoolf

Please remember to update the entry for Graphql/IDType in .rubocop_todo.yml once a file has been fixed!

Edited by Sean Arnold