[VSA] Apply filters to the "Tasks by type" (previously "Type of Work") chart

@ljlane I think that comment was in relation to the Days to completion chart. The discussions for the type of work chart filtering are still unresolved.

Days to completion	Type of work

I'd be expecting we would want to remove the label filtering for the type of work chart and inherit them from the filter bar, the subject filter still makes sense to me though (issues / merge requests).

Thoughts @npost @wortschi ?

@npost

What do you think of the proposal @ekigbo made

I'd be expecting we would want to remove the label filtering for the type of work chart and inherit them from the filter bar, the subject filter still makes sense to me though (issues / merge requests).

Is this something we should plan on working on in the near future? If I recall correctly, the separate label filters have caused quite some UX confusion in the past. /cc @ljlane

I've got an idea to address this. Let me show you some designs in a bit.

@wortschi @ekigbo

Filtering

With #331261 (closed) as the greater context. I think we could simplify this chart by only displaying workflow items (configured in the settings). Therefore, the filters will work as an AND operator on top of workflow item types. For example...

No filter

4x feature
5x ~vulnerability
3x ~"technical debt"
4x ~bug
Total: 16 workflow items

Filter applied (e.g. groupoptimize)

2x feature
2x ~vulnerability
1x ~"technical debt"
1x ~bug
Total: 6 workflow items

Badge

We could also ensure that we signify that this chart has been filtered with a badge next to the title (I may need to add this to the design system)...

Maybe clicking on the badge could scroll you to the filters.

cc @ljlane

@npost thanks for the ping, I just have a few questions:

In #331261[Value_stream_settings.png], i'm not sure i understand what Issue types would that be items like issues, MRs, pipelines etc?
Generally I think i like the settings concept, would we make that the only place to configure a value stream? (ie. move the form out of the modal window?)
Just confirming, all selected filters would be applied to the chart (milestone, author etc)

i'm not sure i understand what Issue types

#118666 (closed)

would we make that the only place to configure a value stream?

Yes

Just confirming, all selected filters would be applied to the chart (milestone, author etc)

Correct. So for example. We could have value stream with groupoptimize. Then we could add filter for the assignee and milestone and see what the distribution of work items were that they completed in that milestone.

@ekigbo

Thanks for the link, and that filtering example makes sense

mentioned in issue #321610

mentioned in issue #322632 (closed)

changed the description

marked this issue as related to #321610

changed epic to &7412

added priority2 label

added UX debt label

added candidate15.1 label

@ekigbo @danmh @blabuschagne

Based on all the feedback above, here is my suggested solution:

On group-level VSA, the "Type of Work" chart will inherit the filters from the filter bar (like they apply to the stage data at the top of the page).
The chart will also inherit the date_range for the top VSA filter bar.
Remove the label filtering for the type of work chart.
Leaving only the option of choosing: issues / merge requests.

Great summary @hsnir1, im in favour of this, it will help simplify the overall page. My only concern would be confirming with backend if the api endpoints for the type of work chart can support all the filters we want to implement. Other than that, I think this proposal is great.

Perhaps @pshutsin or @m_frankiewicz might know?

It would make sense to do this all in one step (apply the filter bar filters as well as remove the old label filtering), but i suspect there might be a little bit of code cleanup needed and tests to update as well.

This would tentatively be weight ~3 to me.

@ekigbo API endpoint should be extended. It does support labels however it doesn't support Milestone, Author and Assignees

Thanks @pshutsin.

@hsnir1 I think the best option would be to schedule a backend issue to extend the API endpoint.

We could possibly remove the type of work label filter and start applying the labels from the filter bar earlier on, but I think this might be more confusing if the other filters arent supported at the same time. So, to me it would be less confusing to introduce all the filters from the filter bar at the same time.

FYI the date_range filter already applies to type of work.

@pshutsin @ekigbo Thank you both. Here is the new backend issue [VSA] API extension for applying filters to the... (#360584 - closed)

this might be more confusing if the other filters arent supported at the same time.

Good point! I'll mark this issue as blocked by the API extension.

added 1 deleted label

All SUS-impacting issues need to have a proper severity label set. Please add those to this issue and remove the automation:ux-missing-labels label.

Hi, @danmh. It's your favorite request. Can you help get a severity label applied? Thanks!

added automation:ux-missing-labels label

added severity3 label

added Next Up label

marked this issue as related to #331261 (closed)

removed automation:ux-missing-labels label

changed the description

mentioned in issue #349793 (closed)

set weight to 3

marked this issue as related to #360584 (closed)

mentioned in issue #360584 (closed)

removed the relation with #360584 (closed)

marked this issue as related to #360584 (closed)

mentioned in issue gitlab-org/manage/general-discussion#17490

added workflowblocked label and removed workflowplanning breakdown label

changed epic to &7961

marked this issue as related to #361159

changed milestone to %15.1

removed candidate15.1 label

added documentation label

added 1 design

removed 1 design

added Stretch label

mentioned in issue #349677 (closed)

@ekigbo the backend for this is done with !88134 (merged).

I'll take off the workflowblocked label.

added workflowready for development label and removed workflowblocked label

added [deprecated] Accepting merge requests label

assigned to @ekigbo

added priority4 label and removed priority2 label

added priority3 label and removed priority4 label

Thanks for working on this @ekigbo! We've removed the Seeking community contributions label to avoid having multiple people working on the same issue.

removed [deprecated] Accepting merge requests label

mentioned in issue #340078

mentioned in issue #222449

marked this issue as related to #337159

mentioned in issue #349679

@ekigbo Following our discussion this morning, I have updated the description with the Acceptance criteria, and also added the Future steps, and link to the reference slides.

Thanks for updating the description @hsnir1, since this issue is scheduled for %15.1 and will provide an iterative improvement, I think we should move the "future steps" to a new related issue.

I think it will probably get missed / lost once this current issue is implemented, so moving the discussion to a new issue gives a good place to properly define the scope of what we would like to achieve, why we want to achieve it and allow an opportunity to discuss how this impacts VSA and find a viable way forward.

@ekigbo sure - here is the new issue - VSA settings page - "Tasks by type" chart - add... (#364386)

changed the description

It would be great to fix #364235 (closed) this at the same time we implement this change.

mentioned in issue #364235 (closed)

mentioned in issue #337159

marked this issue as related to #349679

marked this issue as related to #364385 (closed)

mentioned in issue #364385 (closed)

marked this issue as related to #364386

mentioned in issue #364386

mentioned in issue gitlab-org/manage/general-discussion#17511

removed Next Up label

changed milestone to %15.2

removed Stretch label

added Deliverable label

changed title from [VSA] Apply filters to the "Type of Work" chart to [VSA] Apply filters to the "Tasks by type" (previously "Type of Work") chart

mentioned in issue gitlab-com/Product#4321 (closed)

removed the relation with #364385 (closed)

mentioned in issue #365941

mentioned in merge request gitlab-com/www-gitlab-com!106781 (merged)

[VSA] Apply filters to the "Tasks by type" (previously "Type of Work") chart

Problem to solve

Proposal

Acceptance Criteria

Future steps

Related links

Designs

Child items ...

Activity

Filtering

No filter

Filter applied (e.g. groupoptimize)

Badge

[VSA] Apply filters to the "Tasks by type" (previously "Type of Work") chart

Problem to solve

Proposal

Acceptance Criteria

Future steps

Related links

Blocks

Is blocked by

Relates to

Activity

Filtering

No filter

Filter applied (e.g. groupoptimize)

Badge