Follow-up from "Resolve "Extended user centric tooltips""
The following discussions from gitlab-ce!23231 should be addressed:
-
@timzallmann started a discussion: (+4 comments) Fix for default avatars that is also broken.
-
@filipa started a discussion: (+5 comments) should we use mockadapter instead?
-
@iamphill started a discussion: (+6 comments) So on hover we create a new Vue instance & then on mouseout we destroy it? Why don't we create it on first hover, then hide & show on mouse interactions after that? It could be potentially expensive to keep doing this on every hover, so doing it once would probably be the preferred way.
-
@ClemMakesApps started a discussion: (+4 comments) Can we add a validation function here for this user object?
-
@ClemMakesApps started a discussion: (+5 comments) @annabeldunstone @tauriedavis are we sure we want to add another color?
yes, I think we should use $t-gray-a-08. (from design system)
-
@ClemMakesApps started a discussion: (+5 comments) Could we break up the css class test to check if it contains each class name. Css class name order can change but the output is still the same, which leads to fragile tests
-
@ClemMakesApps started a discussion: (+1 comment) I'm slightly worried that this fixture will get out of sync with our HAML. Could we just reference a generated fixture instead?
-
@ClemMakesApps started a discussion: (+1 comment) I'm worried about this fixture, same concern as https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/23231/diffs#note_123332254