Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab
GitLab
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 36,996
    • Issues 36,996
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 1,446
    • Merge requests 1,446
  • Requirements
    • Requirements
    • List
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLabGitLab
  • Issues
  • #254666

Closed
Open
Created Sep 22, 2020 by Dustin Matzel@dustin1358✈

Service Desk wrong link for attachments

Summary

Attachments in Service Desk (e.g. PDFs) are converted to incomplete links in the repsond email (when using the new_note.md template). These links are missing the url of the GitLab instance. Therefore the files cannot be accessed/downloaded through the link.

Steps to reproduce

  1. Create Issue via Service Desk.
  2. Comment on Issue with a PDF as an attachment.
  3. Open respond email which contains the comment and link to the PDF.
  4. Click on link.

Example Project

This bug occurs in the (self hosted) GitLab Community Edition 13.3.6 and on gitlab.com.

What is the current bug behavior?

The link in the email has the following format which is missing the url of the GitLab instance.

<p data-sourcepos="7:1-7:126" dir="auto"><a href="/group/subgroup/project/uploads/0f50b04c611f9447ecc6194ab5807ffb/filename.pdf" data-link="true" class="gfm">filename.pdf</a></p>

What is the expected correct behavior?

When I add the url of the GitLab instance in markdown of the comment (after uploading the PDF file in the comment and before sending the comment) the email constains the following working link:

<p data-sourcepos="7:1-7:177" dir="auto"><a href="https://url_of_gitlab_instance.de/group/subgroup/project/uploads/5ed963600ae275db19d5016e38fbd59d/filename.pdf">filename.pdf</a></p>

Related Issues:

Comment in different issue (#11733) reported the same behaviour.

Possible fixes

Add url of GitLab instance to link.

Edited Oct 20, 2020 by Dustin Matzel
Assignee
Assign to
13.6
Milestone
13.6 (Past due)
Assign milestone
Time tracking