Follow-up from "Add a system note on Alert creation"
The following discussion from !40128 (merged) should be addressed:
-
@splattael started a discussion: Non-blocking suggestion Ideally, we want to define this hardcoded string as:
SystemNoteService.create_new_alert(alert, Gitlab::AlertManagement::AlertParams::MONITORING_TOOLS[:generic]))
It seems, we have two definitions of
MONITORING_TOOLS
which could be unified:Let's follow-up on this :mucs
-
Add a :generic
entry toMONITORING_TOOLS
to avoid a hard-coded 'Generic Alert Endpoint' string in system note creation
Edited by Peter Leitzen