Align designs displaying activites with available solutions
Problem to solve
In #36500 (closed) (implementation: #215684 (closed)) will display when auto-created merge request are created (opt-in by default) or when solutions are available (opt-out of auto-fix).
The design may be out-of-date per changes on the vulnerability list. https://gitlab.com/gitlab-org/gitlab/uploads/a04ea59d88df8a7da1fad3f81e5260ef/c.png
Solution ideation
Revisions (see designs):
- Adds filter capability by:
- Addition of
With Merge Request
andWith auto-fix solution
items in activity filter (follow up add to: #230381 (closed))
- Addition of
- Lightbulb icon displays in the activities column when auto-created MR exists and/or suggested solution
- Showing the MR is a post-MVC
Implementation plan
backend backend-weight3
- Iteration 1
- Add available auto-fix solutions and associated merge requests to
Vulnerability
type in GraphQL.
- Add available auto-fix solutions and associated merge requests to
- Iteration 2
- Add a field for Merge Request to identify if it's created with auto-fix bot.
frontend
- Iteration 1
- Extend the client-side GraphQL fragment to include available solutions and open Merge Requests (including the distinction between manual MRs and autofix ones).
- Based on the fetched data, display the lightbulb icon in the Activity column when a vulnerability has available solutions.
- Iteration 2
- Add ability to filter by "With Auto-fix solution".
- Iteration 3
- Add the MR popover.
- Add the ability to filter by "With Merge Request".
documentation frontend-weight1
- Add information to https://docs.gitlab.com/ee/user/application_security/security_dashboard/#vulnerability-report about the new filtering capabilities.
Edited by Tetiana Chupryna