Follow-up from "Wire up GraphQL query to dynamic form"
The following discussions from !38318 (merged) should be addressed:
-
@markrian started a discussion: (+3 comments) @beckalippert Would you review some pieces of the UX here, please? In particular:
- I've updated the SAST Configuration UI's subheading text to comply with the latest designs, although I'm not 100% sure about the wording.
- I added an error state in the case the configuration data couldn't be loaded (this is a non-user-recoverable problem). The alert shown is non-dismissible. I'm not sure on the wording here, either
😅 - The
Loaded
screenshot in the description doesn't quite align with the designs - particularly, the input sizes are wrong and the default value isn't being set correctly. These will be fixed by additional backend changes in another MR.
Thanks!
-
@markrian started a discussion: (+1 comment) Do we want to use abbreviations like
docs
in the UI? cc @beckalippert -
@markrian started a discussion: (+2 comments) This error message would only be shown if something has gone badly wrong (e.g., the backend is down, or the user's connection is down). Is suggesting that they reload the page the right advice? cc @beckalippert
Implementation plan
-
Apply change described in !38318 (comment 390966711) -
Apply change described in #233910 (comment 392199031)
Edited by Mark Florian