Refresh old references to feature flags in the docs
Problem to solve
There are lots of old feature flags mentioned in the docs that should be reviewed. My intention isn't for people to actively focus on this. It's just that when we run across an old/unexpected/strange mention of a feature flag in our groups, and we can spare the time, to ask our teams if a feature flag note is still valid.
These old feature flags:
- Might not even exist in the codebase anymore.
- Might be using a non-standard style to explain them, if they do still exist.
The TW team should keep an eye out for these, and when they run across them they can ask their groups if the feature flags still exist. If the flags still exist, we should update the docs to match the current documentation style. This will help to find these references in the future, if they are all standardized, and make them "less suspicious".
Current docs templates for feature flags: https://docs.gitlab.com/ee/development/documentation/feature_flags.html
For example:
- https://docs.gitlab.com/ee/user/project/merge_requests/merge_request_approvals.html#enabling-the-new-approvals-interface. Is this an enabled-by-default feature flag, and can be disabled, or just general available without any feature flags?
Turns out, it was NOT correct, and needed to be updated (MR submitted).