Pipelines for merged results cannot be skipped with `[ci skip]`
Problem
Pipelines for merged results run on a prospective merge commit (refs/merge-requests/:iid/merge
). This commit looks like the following:
Merge branch '199718-remove-jump-btn-in-mr-thread' into 'master'
Add feature flag for jump to next unresolved button in threads
Closes #199718
See merge request !37873
This completely wipes out the source commit message (which contains [ci skip]
) therefore, the pipeline cannot be skipped.
Proposal
- When creating a merged results pipeline, use
pipeline.source_sha
instead ofpipeline.sha
when deciding whether to skip the pipeline. See here for a rough context of where it happens. Important: This should only apply to merged results pipelines, not merge trains and not detached merge merge request pipelines (explanation). - Use a feature flag to roll it out, in case some customers are relying on the name of the refs, we could roll it back
Edited by Hordur Freyr Yngvason