Geo: `rake gitlab:uploads:check` dies when an associated model raises error on instantiation
From Slack discussion:
I’m verifying uploads on GPRD but the task breaks when
Note
s try to setdiscussion_id
inafter_initialize
. I didn’t see these errors in the task a month ago.I’m planning to work around this by instantiating all 8k notes that have uploads, on the primary, to ensure their
discussion_id
is set. Please LMK if I should not do thisIt was a total of 4
Note
s that had anUpload
that haddiscussion_id: nil
. They all got set properly on the primary
At the very least, shouldn't the error be captured as a failure so the task can continue? Maybe the recent changes broke that part? https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/19501 https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/20012