Geo: Add final confirmation to promotion script
Problem to solve
We currently have a number of preflight checks included when using gitlab-ctl promote-to-primary-node
; however, we don't have an independent "final" confirmation if users want to proceed.
This leads to a situation where gitlab-ctl promote-to-primary-node
can be run with --skip-preflight-check
and it will just promote, no further questions asked. That is maybe not surprising but it feels a bit harsh.
Intended users
User experience goal
Make sure that the system administrator does not promote their secondary by accident.
Proposal
Add a final confirmation to gitlab-ctl promote-to-primary-node
e.g.
> `gitlab-ctl promote-to-primary-node`
..... Preflight checks (can be skipped)
You are about to promote this secondary node to become a new primary. Are you sure? (No/YES)
Documentation
I don't think we need to update much
Availability & Testing
- Unit test changes
- Integration test changes
- End-to-end test change
See the test engineering planning process and reach out to your counterpart Software Engineer in Test for assistance: https://about.gitlab.com/handbook/engineering/quality/test-engineering/#test-planning -->
What does success look like, and how can we measure that?
Confirmation is displayed when running gitlab-ctl promote-to-primary-node
What is the type of buyer?
Is this a cross-stage feature?
- Premium