Flaky: spec/features/merge_request/user_suggests_changes_on_diff_spec.rb:158 User comments on a diff applying suggestions in batches can apply multiple suggestions as a batch
Job #608489567 failed for 48967434:
rspec ./spec/features/merge_request/user_suggests_changes_on_diff_spec.rb:158 # User comments on a diff applying suggestions in batches can apply multiple suggestions as a batch
1) User comments on a diff applying suggestions in batches can apply multiple suggestions as a batch
Got 1 failure and 1 other error:
1.1) Failure/Error: expect(page).to have_content('Applied').twice
expected to find text "Applied" 2 times but found 0 times in "Skip to content GitLab Projects Groups More Help P project23 Project overview Repository Issues 0 Merge Requests 1 CI / CD Operations Analytics Wiki Snippets Members Settings Collapse sidebar John Doe32 project23 Merge Requests !1 Open Opened just now by John Doe32 Edit Close merge request My title 23 Overview 2 Commits 5 Changes 8 All threads resolved Compare feature and latest version 8 files + 20 - 6 .DS_Store deleted + 0 - 0 .DS_Store Download .gitignore + 1 - 0 Show unchanged lines pickle-email-*.html .project config/initializers/secret_token.rb .DS_Store .gitmodules + 6 - 0 [submodule \"six\"] path = six url = git://github.com/randx/six.git [submodule \"gitlab-shell\"] path = gitlab-shell url = https://github.com/gitlabhq/gitlab-shell.git [submodule \"gitlab-grack\"] path = gitlab-grack url = https://gitlab.com/gitlab-org/gitlab-grack.git files/.DS_Store deleted + 0 - 0 .DS_Store Download files/ruby/popen.rb + 10 - 3 require 'fileutils' require 'open3' module Popen extend self def popen(cmd, path=nil) unless cmd.is_a?(Array) raise \"System commands must be given as an array of strings\" raise RuntimeError, \"System commands must be given as an array of strings\" end path ||= Dir.pwd John Doe33 @user31 · just now Maintainer Suggested change Add suggestion to batch Apply suggestion 12 path ||= Dir.pwd 12 # change to a comment Reply... Resolve thread Start a new discussion... vars = { \"PWD\" => path } options = { chdir: path } vars = { \"PWD\" => path } options = { chdir: path } unless File.directory?(path) FileUtils.mkdir_p(path) end @cmd_output = \"\" @cmd_status = 0 Open3.popen3(vars, *cmd, options) do |stdin, stdout, stderr, wait_thr| @cmd_output << stdout.read @cmd_output << stderr.read @cmd_status = wait_thr.value.exitstatus end return @cmd_output, @cmd_status end end files/ruby/regex.rb + 1 - 3 module Gitlab module Regex extend self def username_regex default_regex end def project_name_regex /\\A[a-zA-Z0-9][a-zA-Z0-9_\\-\\. ]*\\z/ end def name_regex /\\A[a-zA-Z0-9_\\-\\. ]*\\z/ end def path_regex default_regex end def archive_formats_regex John Doe33 @user31 · just now Maintainer Suggested change Add suggestion to batch Apply suggestion 21 def archive_formats_regex 21 # change to a comment Reply... Resolve thread Start a new discussion... #|zip|tar| tar.gz | tar.bz2 | /(zip|tar|tar\\.gz|tgz|gz|tar\\.bz2|tbz|tbz2|tb2|bz2)/ /(zip|tar|7z|tar\\.gz|tgz|gz|tar\\.bz2|tbz|tbz2|tb2|bz2)/ end def git_reference_regex # Valid git ref regex, see: # https://www.kernel.org/pub/software/scm/git/docs/git-check-ref-format.html %r{ (?! (?# doesn't begins with) \\/| (?# rule #6) (?# doesn't contain) .*(?: [\\/.]\\.| (?# rule #1,3) \\/\\/| (?# rule #6) @\\{| (?# rule #8) \\\\ (?# rule #9) ) ) [^\\000-\\040\\177~^:?*\\[]+ (?# rule #4-5) (?# doesn't end with) (?<!\\.lock) (?# rule #1) (?<![\\/.]) (?# rule #6-7) }x end protected def default_regex /\\A[.?]?[a-zA-Z0-9][a-zA-Z0-9_\\-\\.]*(?<!\\.git)\\z/ end end end gitlab-grack @ 645f6c4c Subproject commit 645f6c4c82fd3f5e06f67134450a570b795e55a6 gitlab-shell @ 79bceae6 Subproject commit 79bceae69cb5750d6567b223597999bfa91cb3b9 To Do Add a To Do 0 Assignees Edit None - assign yourself Milestone Edit None Time tracking No estimate or time spent Labels Edit None Lock merge request Edit Unlocked 1 participant Notifications Reference: namespace23/project23!1 This also resolves the discussion". (However, it was found 2 times including non-visible text.)
# ./vendor/ruby/2.6.0/gems/rspec-support-3.9.2/lib/rspec/support.rb:97:in `block in <module:Support>'
# ./vendor/ruby/2.6.0/gems/rspec-support-3.9.2/lib/rspec/support.rb:106:in `notify_failure'
# ./vendor/ruby/2.6.0/gems/rspec-expectations-3.9.1/lib/rspec/expectations/fail_with.rb:35:in `fail_with'
# ./vendor/ruby/2.6.0/gems/rspec-expectations-3.9.1/lib/rspec/expectations/handler.rb:40:in `handle_failure'
# ./vendor/ruby/2.6.0/gems/rspec-expectations-3.9.1/lib/rspec/expectations/handler.rb:50:in `block in handle_matcher'
# ./vendor/ruby/2.6.0/gems/rspec-expectations-3.9.1/lib/rspec/expectations/handler.rb:27:in `with_matcher'
# ./vendor/ruby/2.6.0/gems/rspec-expectations-3.9.1/lib/rspec/expectations/handler.rb:48:in `handle_matcher'
# ./vendor/ruby/2.6.0/gems/rspec-expectations-3.9.1/lib/rspec/expectations/expectation_target.rb:65:in `to'
# ./spec/features/merge_request/user_suggests_changes_on_diff_spec.rb:186:in `block (3 levels) in <top (required)>'