Show clone button on project page for "Activity" Preference
Original Issue > #204904 (closed)
MR | Changes |
---|---|
Part 1 > !33023 (merged) | Update Readme Page |
|
Update Activity Page |
Display the clone button on project for non-default Actvitity preference
![](/-/project/278964/uploads/6e17658421036246b39c8f133c8c999b/image.png)
Requirements
Must solve these issues that were brought up during the review of the original MR
Issue 1A
-
@pslaughter started a discussion: (+1 comment) issue: Looks like there's an issue with the clone button and the activity view
😞 20200711_issue_clone_dropdown_hidden
I'm on Firefox testing on the
gitlab-org/gitlab-test
project. For some reason, it looks like the dropdown is hidden by the activity feed🤷
Solution (but this solution will cause problem Issue 1B)
app/assets/stylesheets/framework/secondary_navigation_elements.scss
Issue 1B
The following discussion from !33023 (merged) should be addressed:
-
@pslaughter started a discussion: (+2 comments) issue (non-blocking): There's a minor issue with removing this
overflow: hidden
Before on master
On this MR It's not very noticeable in English, but in other languages these tabs can cause an overflow which doesn't look pretty
🤷
Issue 2
The following discussion from !33023 (merged) should be addressed:
-
@pslaughter started a discussion: (+2 comments) issue: It looks like this will also add the clone button to the "Activities" page:
Also, it's important to keep in mind that it's possible to disable the Repository for a project altogether, in which case we also do not want to show the clone button.
Project settings Project homepage IMHO, this is a blocker and unfortunately I'm not sure what the best approach is here... Since the
_readme
part isn't blocked by anything, I suggest handling the_activity
bit in a separate MR and rescoping this one to just include the changes necessary for the_readme
view.🤔