Suggest to run RUN AS-IF-FOSS when too many test files detected in rspec foss-impact
Refactoring and chore MRs (such as Rubocop changes, Rails upgrade, linting, etc), may touch a large number of files, but do not change EE & FOSS structure. In this case, the rspec foss-impact
could time out due to large number of test files to run.
Examples of such MRs:
-
!33740 (merged) (600 test files changed and
rspec foss-impact
timed out after 120 minutes)
New solution based on discussion:
- Do not
foss impact
when the title includesRUN AS-IF-FOSS
(or more generally speaking, don't run it when we're running FOSS tests) -
foss impact
should fail directly without running any tests when there are more thanN
files detected and ask the author to update the merge request title to containRUN AS-IF-FOSS
so that we can just utilize the existing FOSS tests better. It's probably also a good chance to tell people that how they can run FOSS tests. - Set N to 20 test files detected
Edited by Albert Salim