Ensure backwards compatibility during transition to Workhorse directly uploading files to S3
The following discussion from !29389 (merged) should be addressed:
-
nick.thomas
started a discussion: (+4 comments)I'm thinking a little about what happens to someone who has already configured AWS object storage when they upgrade. Is there any possibility that defaulting to enabled, as opposed to (say) making this a selectable thing, would break previously-working configurations? Or are all the configurations we're changing the behaviour for already broken?
I propose:
-
Make this a feature flag that is disabled by default and document that. I don't want to add another configuration parameter for all the object storage providers. -
Consolidate the object storage parameters to use different buckets (#23345 (closed)). -
Once consolidated, add a new configuration parameter there to enable Workhorse S3 uploads: !35480 (merged) -
Test the AWS SDK with Oracle Cloud (just asked my contact there) and other S3 providers. -
Add support for V2/V4 signature configuration between Workhorse and RailsV4 is only supported in the AWS SDK
Other issues to consider:
-
Add support for specifying AWS credentials in Workhorse config: omnibus-gitlab!4368 (merged) -
Add support for adding S3 encryption keys: #226006
Edited by Stan Hu