Change primary button for editing on files
Problem to Solve
The Web IDE is a more complete editing experience that helps to facilitate workflows across multiple files and merge requests. However, users favor the single file editing experience.
Additional Details
This is a test that should be setup behind a feature flag to see what kind/if any feedback is generated by making this change.
Proposal
The primary and inverted buttons of Edit
and Web IDE
should be switched so that Web IDE more clearly looks like a primary action that users should perform.
Feature Flag
The web_ide_primary_edit
feature flag has been enabled for gitlab-org
and gitlab-com
groups. It can be turned off by running the following chatops commands in slack:
/chatops run feature set --group=gitlab-org web_ide_primary_edit false
/chatops run feature set --group=gitlab-com web_ide_primary_edit false
Original feature flag requirements
This feature needs to be done with a feature flag and it would be good to have the ability to either assign groups to the feature or assign individual users depending on what we want to do for testing.
We SHOULD NOT enable this by default in the %13.2 release, but rather at a minimum toggle the feature flag on for gitlab-org
and gitlab-com
.
Feature flag implementation documentation
Feature Flag implemenation
!35957 (merged) Introduces web_ide_primary_edit
feature flag that can be anabled for a group.
Instrumentation
It would be good as part of this to add telemetry to these buttons to see how many clicks each button receives: https://docs.gitlab.com/ee/development/telemetry/snowplow.html#implementing-snowplow-js-frontend-tracking
There is also a basic A/B test process documented here: https://docs.gitlab.com/ee/development/experiment_guide/#how-to-create-an-ab-test
Tracking implementation
Clicking the edit buttons will trigger the following events.
event | label | property | |
---|---|---|---|
click_edit |
Edit |
||
click_edit |
Edit |
secondary |
|
click_edit_ide |
Web IDE |
||
click_edit_ide |
Web IDE |
secondary |