Skip to content

GitLab Next

Closed
Opened by Samantha Ming@sming-gitlabDeveloper0 of 1 task completed0/1 task

Add empty state when search by "Author" & "Filter by commit message" renders no result

The following discussion from !28509 (merged) should be addressed:

  • @sming-gitlab started a discussion: (+2 comments)

    Opportunity for Improvement 2: Blank page for no results found

    Currently, if no commits are found for the specific author, a blank page will appear. This is consistent with the behaviour of "Filter by commit message".

    image

    A better experience is to add some sort of message. Maybe there is some design you can come up with and we can address this in a separate issue? -- and have that as the result of both no author or commit message found

Solution

@pedroms I suggested tweaking that empty state to this: image Maybe we can re-use that illustration and change the text to:

Title: Your search didn't match any commits.
Paragraph: Try changing or removing filters.

And ignore that button, naturally 🙂

Note

A temporary solution has been implemented here MR !29306 (merged)

Once this issue is resolved, make sure to remove the changes made in that MR

Edited by Samantha Ming