Use Workhorse for all requests that use WorkhorseHelpers
We have a lot of upload-related specs that use WorkhorseHelpers
to simulate uploads with Workhorse in the loop:
$ git grep "include WorkhorseHelpers" spec
spec/controllers/groups/uploads_controller_spec.rb: include WorkhorseHelpers
spec/controllers/projects/uploads_controller_spec.rb: include WorkhorseHelpers
spec/controllers/uploads_controller_spec.rb: include WorkhorseHelpers
spec/requests/api/group_import_spec.rb: include WorkhorseHelpers
spec/requests/api/project_import_spec.rb: include WorkhorseHelpers
spec/requests/api/project_snapshots_spec.rb: include WorkhorseHelpers
spec/requests/api/repositories_spec.rb: include WorkhorseHelpers
spec/requests/api/runner_spec.rb: include WorkhorseHelpers
spec/requests/api/wikis_spec.rb: include WorkhorseHelpers
spec/requests/git_http_spec.rb: include WorkhorseHelpers
spec/requests/import/gitlab_projects_controller_spec.rb: include WorkhorseHelpers
spec/requests/lfs_http_spec.rb: include WorkhorseHelpers
spec/requests/lfs_locks_api_spec.rb: include WorkhorseHelpers
spec/requests/projects/uploads_spec.rb: include WorkhorseHelpers
spec/support/helpers/git_http_helpers.rb: include WorkhorseHelpers
spec/support/helpers/lfs_http_helpers.rb: include WorkhorseHelpers
I think we should stop using this helper and activate !24000 (merged) for these cases. Perhaps we should just use Workhorse regardless, starting with all API requests.
/cc: @nick.thomas, @rymai