HTTPS URL for projects displayed on a project page includes a username
Summary
After an upgrade to GLEE 9.02, we run into this issue when https URLs displayed on project pages include a user's ID. what previously showed
https://gitlab.a2i2.c/sa-apps/Xxxx.git
now has e. g.
https://kkm@gitlab.a2i2.c/sa-apps/Xxxx.git
We are using kerberos to authenticate, and these URLs break it down when people copy them from project pages (and everybody so used to just copying the URL, so this is a serious breakage for us)
Steps to reproduce
Looks like this happens to all users, we just did not hit the worst of the wave of incorrectly cloned repositories. Just go to project page of a Kerberized installation of GLEE, and the URL includes a user name.
What is the expected correct behavior?
https://gitlab.a2i2.c/sa-apps/Xxxx.git
so that Kerberos is not broken by default.
Results of GitLab environment info
# gitlab-rake gitlab:env:info
System information
System: Ubuntu 14.04
Proxy: no
Current User: git
Using RVM: no
Ruby Version: 2.3.3p222
Gem Version: 2.6.6
Bundler Version:1.13.7
Rake Version: 10.5.0
Redis Version: 3.2.5
Git Version: 2.10.2
Sidekiq Version:4.2.7
GitLab information
Version: 9.0.2-ee
Revision: 3ed6218
Directory: /opt/gitlab/embedded/service/gitlab-rails
DB Adapter: postgresql
DB Version: 9.6.1
URL: https://gitlab.a2i2.c
HTTP Clone URL: https://gitlab.a2i2.c/some-group/some-project.git
SSH Clone URL: git@gitlab.a2i2.c:some-group/some-project.git
Elasticsearch: no
Geo: no
Using LDAP: yes
Using Omniauth: yes
Omniauth Providers: kerberos_spnego
GitLab Shell
Version: 5.0.0
Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories
Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks/
Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
# gitlab-rake gitlab:check SANITIZE=true
Checking GitLab Shell ...
GitLab Shell version >= 5.0.0 ? ... OK (5.0.0)
Repo base directory exists?
default... yes
Repo storage directories are symlinks?
default... no
Repo paths owned by git:git?
default... yes
Repo paths access is drwxrws---?
default... yes
hooks directories in repos are links: ...
2/2 ... ok
2/3 ... ok
3/4 ... ok
3/5 ... ok
2/6 ... ok
5/7 ... ok
2/8 ... ok
5/9 ... ok
5/10 ... ok
18/13 ... ok
2/14 ... ok
5/15 ... ok
18/17 ... ok
18/18 ... ok
2/20 ... ok
2/21 ... ok
2/22 ... ok
18/23 ... ok
17/25 ... ok
18/26 ... ok
18/27 ... ok
33/28 ... ok
22/30 ... ok
27/31 ... ok
27/33 ... ok
26/34 ... repository is empty
18/36 ... ok
22/37 ... ok
18/38 ... ok
27/40 ... ok
26/41 ... ok
5/43 ... ok
17/44 ... ok
32/45 ... ok
2/46 ... ok
16/47 ... ok
31/49 ... ok
16/50 ... ok
34/54 ... ok
17/57 ... ok
46/58 ... ok
17/60 ... ok
17/61 ... ok
34/67 ... ok
17/69 ... ok
34/70 ... ok
17/71 ... ok
3/72 ... ok
2/73 ... ok
35/74 ... ok
17/76 ... ok
18/77 ... ok
16/79 ... ok
17/80 ... ok
17/81 ... ok
35/82 ... ok
18/83 ... ok
35/84 ... ok
18/85 ... ok
17/86 ... ok
2/87 ... ok
17/90 ... ok
18/92 ... ok
35/93 ... ok
29/94 ... ok
34/95 ... ok
17/97 ... ok
5/98 ... ok
16/103 ... ok
29/104 ... ok
23/105 ... ok
34/106 ... ok
34/107 ... ok
23/108 ... ok
19/109 ... ok
23/110 ... ok
27/111 ... repository is empty
27/113 ... ok
16/114 ... repository is empty
46/115 ... ok
17/116 ... ok
46/118 ... ok
17/119 ... ok
34/120 ... ok
17/121 ... ok
27/124 ... ok
34/125 ... ok
29/126 ... ok
34/127 ... ok
24/128 ... ok
34/129 ... ok
22/130 ... ok
35/131 ... ok
26/132 ... ok
24/134 ... ok
34/136 ... ok
35/137 ... ok
27/138 ... ok
34/139 ... ok
24/140 ... ok
34/141 ... ok
23/142 ... ok
34/143 ... ok
19/144 ... ok
34/145 ... ok
35/146 ... ok
34/147 ... ok
23/148 ... ok
24/151 ... ok
19/152 ... ok
34/153 ... ok
19/154 ... ok
34/155 ... ok
35/156 ... ok
46/157 ... ok
17/158 ... ok
34/159 ... ok
19/160 ... ok
34/161 ... ok
16/162 ... ok
16/163 ... ok
22/164 ... repository is empty
42/165 ... ok
34/166 ... ok
19/167 ... ok
34/168 ... ok
34/169 ... ok
23/170 ... ok
29/171 ... ok
16/172 ... ok
16/173 ... ok
16/174 ... ok
16/175 ... ok
34/176 ... ok
19/177 ... ok
34/178 ... ok
43/179 ... ok
34/180 ... ok
22/181 ... ok
34/182 ... ok
35/183 ... ok
34/184 ... ok
17/188 ... ok
34/189 ... ok
34/191 ... ok
34/195 ... ok
34/197 ... ok
34/199 ... ok
34/201 ... ok
34/203 ... ok
34/205 ... ok
34/207 ... ok
34/209 ... ok
34/213 ... ok
34/216 ... ok
34/218 ... ok
34/220 ... ok
34/222 ... ok
34/224 ... ok
34/225 ... ok
34/226 ... ok
34/228 ... ok
19/230 ... ok
19/231 ... ok
34/232 ... ok
34/234 ... ok
34/236 ... ok
34/238 ... ok
34/240 ... ok
24/242 ... ok
34/243 ... ok
34/245 ... ok
34/247 ... ok
34/249 ... ok
34/251 ... ok
34/253 ... ok
34/255 ... ok
34/257 ... ok
34/259 ... ok
34/261 ... ok
34/263 ... ok
34/265 ... ok
34/267 ... ok
34/269 ... ok
34/271 ... ok
34/273 ... ok
34/275 ... ok
34/277 ... ok
22/278 ... ok
16/286 ... ok
17/287 ... ok
43/288 ... ok
43/290 ... ok
22/291 ... ok
22/292 ... ok
22/293 ... ok
34/295 ... ok
35/296 ... ok
2/298 ... ok
34/299 ... ok
45/300 ... ok
34/301 ... ok
34/302 ... ok
19/303 ... ok
19/304 ... ok
34/305 ... ok
23/306 ... ok
43/307 ... ok
34/309 ... ok
43/310 ... ok
34/311 ... ok
45/312 ... ok
24/313 ... ok
43/314 ... ok
47/315 ... ok
47/316 ... ok
34/317 ... ok
47/319 ... ok
47/320 ... ok
34/321 ... ok
34/322 ... ok
48/323 ... ok
47/324 ... ok
2/325 ... ok
43/326 ... ok
45/327 ... ok
19/329 ... ok
45/330 ... ok
24/331 ... ok
24/332 ... ok
47/334 ... ok
43/335 ... ok
34/336 ... ok
48/337 ... ok
47/341 ... ok
34/342 ... ok
35/343 ... ok
27/344 ... ok
34/345 ... ok
43/346 ... ok
48/348 ... ok
47/349 ... ok
21/350 ... ok
21/352 ... repository is empty
45/353 ... ok
17/354 ... ok
34/355 ... ok
43/356 ... ok
34/357 ... ok
43/358 ... ok
48/360 ... ok
51/363 ... ok
51/364 ... ok
45/365 ... ok
45/366 ... ok
43/367 ... ok
43/369 ... ok
16/370 ... ok
45/371 ... ok
23/372 ... ok
18/373 ... ok
34/374 ... ok
43/375 ... ok
45/376 ... ok
34/377 ... ok
47/378 ... ok
43/379 ... ok
34/380 ... ok
19/381 ... ok
45/382 ... ok
53/383 ... ok
53/385 ... ok
35/387 ... ok
43/388 ... ok
23/389 ... ok
27/390 ... repository is empty
34/391 ... ok
43/392 ... ok
24/393 ... ok
35/394 ... ok
51/395 ... ok
53/396 ... ok
24/397 ... ok
53/398 ... ok
53/399 ... ok
34/400 ... ok
48/401 ... ok
54/402 ... ok
43/403 ... ok
45/404 ... ok
45/405 ... ok
35/406 ... ok
43/407 ... ok
45/408 ... ok
34/409 ... ok
43/410 ... ok
54/411 ... ok
45/412 ... ok
43/413 ... ok
43/414 ... ok
56/415 ... ok
43/416 ... ok
24/417 ... ok
43/418 ... ok
35/419 ... ok
23/420 ... ok
48/421 ... ok
48/422 ... ok
42/423 ... ok
2/424 ... ok
34/425 ... ok
43/426 ... ok
35/427 ... ok
26/428 ... ok
22/430 ... ok
35/431 ... ok
43/432 ... ok
2/433 ... ok
45/434 ... ok
47/435 ... ok
45/436 ... ok
27/437 ... ok
24/438 ... ok
24/439 ... ok
53/440 ... ok
19/441 ... repository is empty
45/442 ... ok
45/443 ... ok
19/444 ... ok
45/445 ... ok
43/446 ... ok
23/447 ... ok
34/449 ... ok
43/450 ... ok
16/451 ... ok
24/452 ... ok
22/453 ... ok
45/454 ... ok
24/455 ... ok
45/456 ... ok
22/457 ... ok
23/458 ... ok
45/459 ... ok
45/460 ... ok
34/462 ... ok
19/463 ... ok
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Check GitLab API access: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK
Send ping to redis server: OK
gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes
Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Reply by email ...
Reply by email is disabled in config/gitlab.yml
Checking Reply by email ... Finished
Checking LDAP ...
Server: ldapmain
LDAP authentication... Success
LDAP users with access to your GitLab server (only showing the first 100 results)
[ STRIPPED -kkm]
Checking LDAP ... Finished
Checking GitLab ...
Git configured with autocrlf=input? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config outdated? ... no
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory setup correctly? ... yes
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
projects have namespace: ...
2/2 ... yes
2/3 ... yes
3/4 ... yes
3/5 ... yes
2/6 ... yes
5/7 ... yes
2/8 ... yes
5/9 ... yes
5/10 ... yes
18/13 ... yes
2/14 ... yes
5/15 ... yes
18/17 ... yes
18/18 ... yes
2/20 ... yes
2/21 ... yes
2/22 ... yes
18/23 ... yes
17/25 ... yes
18/26 ... yes
18/27 ... yes
33/28 ... yes
22/30 ... yes
27/31 ... yes
27/33 ... yes
26/34 ... yes
18/36 ... yes
22/37 ... yes
18/38 ... yes
27/40 ... yes
26/41 ... yes
5/43 ... yes
17/44 ... yes
32/45 ... yes
2/46 ... yes
16/47 ... yes
31/49 ... yes
16/50 ... yes
34/54 ... yes
17/57 ... yes
46/58 ... yes
17/60 ... yes
17/61 ... yes
34/67 ... yes
17/69 ... yes
34/70 ... yes
17/71 ... yes
3/72 ... yes
2/73 ... yes
35/74 ... yes
17/76 ... yes
18/77 ... yes
16/79 ... yes
17/80 ... yes
17/81 ... yes
35/82 ... yes
18/83 ... yes
35/84 ... yes
18/85 ... yes
17/86 ... yes
2/87 ... yes
17/90 ... yes
18/92 ... yes
35/93 ... yes
29/94 ... yes
34/95 ... yes
17/97 ... yes
5/98 ... yes
16/103 ... yes
29/104 ... yes
23/105 ... yes
34/106 ... yes
34/107 ... yes
23/108 ... yes
19/109 ... yes
23/110 ... yes
27/111 ... yes
27/113 ... yes
16/114 ... yes
46/115 ... yes
17/116 ... yes
46/118 ... yes
17/119 ... yes
34/120 ... yes
17/121 ... yes
27/124 ... yes
34/125 ... yes
29/126 ... yes
34/127 ... yes
24/128 ... yes
34/129 ... yes
22/130 ... yes
35/131 ... yes
26/132 ... yes
24/134 ... yes
34/136 ... yes
35/137 ... yes
27/138 ... yes
34/139 ... yes
24/140 ... yes
34/141 ... yes
23/142 ... yes
34/143 ... yes
19/144 ... yes
34/145 ... yes
35/146 ... yes
34/147 ... yes
23/148 ... yes
24/151 ... yes
19/152 ... yes
34/153 ... yes
19/154 ... yes
34/155 ... yes
35/156 ... yes
46/157 ... yes
17/158 ... yes
34/159 ... yes
19/160 ... yes
34/161 ... yes
16/162 ... yes
16/163 ... yes
22/164 ... yes
42/165 ... yes
34/166 ... yes
19/167 ... yes
34/168 ... yes
34/169 ... yes
23/170 ... yes
29/171 ... yes
16/172 ... yes
16/173 ... yes
16/174 ... yes
16/175 ... yes
34/176 ... yes
19/177 ... yes
34/178 ... yes
43/179 ... yes
34/180 ... yes
22/181 ... yes
34/182 ... yes
35/183 ... yes
34/184 ... yes
17/188 ... yes
34/189 ... yes
34/191 ... yes
34/195 ... yes
34/197 ... yes
34/199 ... yes
34/201 ... yes
34/203 ... yes
34/205 ... yes
34/207 ... yes
34/209 ... yes
34/213 ... yes
34/216 ... yes
34/218 ... yes
34/220 ... yes
34/222 ... yes
34/224 ... yes
34/225 ... yes
34/226 ... yes
34/228 ... yes
19/230 ... yes
19/231 ... yes
34/232 ... yes
34/234 ... yes
34/236 ... yes
34/238 ... yes
34/240 ... yes
24/242 ... yes
34/243 ... yes
34/245 ... yes
34/247 ... yes
34/249 ... yes
34/251 ... yes
34/253 ... yes
34/255 ... yes
34/257 ... yes
34/259 ... yes
34/261 ... yes
34/263 ... yes
34/265 ... yes
34/267 ... yes
34/269 ... yes
34/271 ... yes
34/273 ... yes
34/275 ... yes
34/277 ... yes
22/278 ... yes
16/286 ... yes
17/287 ... yes
43/288 ... yes
43/290 ... yes
22/291 ... yes
22/292 ... yes
22/293 ... yes
34/295 ... yes
35/296 ... yes
2/298 ... yes
34/299 ... yes
45/300 ... yes
34/301 ... yes
34/302 ... yes
19/303 ... yes
19/304 ... yes
34/305 ... yes
23/306 ... yes
43/307 ... yes
34/309 ... yes
43/310 ... yes
34/311 ... yes
45/312 ... yes
24/313 ... yes
43/314 ... yes
47/315 ... yes
47/316 ... yes
34/317 ... yes
47/319 ... yes
47/320 ... yes
34/321 ... yes
34/322 ... yes
48/323 ... yes
47/324 ... yes
2/325 ... yes
43/326 ... yes
45/327 ... yes
19/329 ... yes
45/330 ... yes
24/331 ... yes
24/332 ... yes
47/334 ... yes
43/335 ... yes
34/336 ... yes
48/337 ... yes
47/341 ... yes
34/342 ... yes
35/343 ... yes
27/344 ... yes
34/345 ... yes
43/346 ... yes
48/348 ... yes
47/349 ... yes
21/350 ... yes
21/352 ... yes
45/353 ... yes
17/354 ... yes
34/355 ... yes
43/356 ... yes
34/357 ... yes
43/358 ... yes
48/360 ... yes
51/363 ... yes
51/364 ... yes
45/365 ... yes
45/366 ... yes
43/367 ... yes
43/369 ... yes
16/370 ... yes
45/371 ... yes
23/372 ... yes
18/373 ... yes
34/374 ... yes
43/375 ... yes
45/376 ... yes
34/377 ... yes
47/378 ... yes
43/379 ... yes
34/380 ... yes
19/381 ... yes
45/382 ... yes
53/383 ... yes
53/385 ... yes
35/387 ... yes
43/388 ... yes
23/389 ... yes
27/390 ... yes
34/391 ... yes
43/392 ... yes
24/393 ... yes
35/394 ... yes
51/395 ... yes
53/396 ... yes
24/397 ... yes
53/398 ... yes
53/399 ... yes
34/400 ... yes
48/401 ... yes
54/402 ... yes
43/403 ... yes
45/404 ... yes
45/405 ... yes
35/406 ... yes
43/407 ... yes
45/408 ... yes
34/409 ... yes
43/410 ... yes
54/411 ... yes
45/412 ... yes
43/413 ... yes
43/414 ... yes
56/415 ... yes
43/416 ... yes
24/417 ... yes
43/418 ... yes
35/419 ... yes
23/420 ... yes
48/421 ... yes
48/422 ... yes
42/423 ... yes
2/424 ... yes
34/425 ... yes
43/426 ... yes
35/427 ... yes
26/428 ... yes
22/430 ... yes
35/431 ... yes
43/432 ... yes
2/433 ... yes
45/434 ... yes
47/435 ... yes
45/436 ... yes
27/437 ... yes
24/438 ... yes
24/439 ... yes
53/440 ... yes
19/441 ... yes
45/442 ... yes
45/443 ... yes
19/444 ... yes
45/445 ... yes
43/446 ... yes
23/447 ... yes
34/449 ... yes
43/450 ... yes
16/451 ... yes
24/452 ... yes
22/453 ... yes
45/454 ... yes
24/455 ... yes
45/456 ... yes
22/457 ... yes
23/458 ... yes
45/459 ... yes
45/460 ... yes
34/462 ... yes
19/463 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.1.0 ? ... yes (2.3.3)
Your git bin path is "/opt/gitlab/embedded/bin/git"
Git version >= 2.7.3 ? ... yes (2.10.2)
Active users: 31
Checking GitLab ... Finished
Possible fixes
- Telling users to delete user name from the copied string every time it is copied.
- Running around in wide circles helping users who forget to strip the username.