Investigate release evidence collection problem during Feb 2020
Summary
Release evidence is no longer being collected for projects on gitlab.com. Based on reviewing all of my projects, the last release with evidence collection was on 2020-01-27 and the the first release with no evidence was on 2020-02-04. The evidence is not shown on the release page, and is also missing from the release summary retrieved from the API.
Steps to reproduce
Create a new release via the API.
Example Project
This project has the most frequent releases, but all projects in this group (and others) have the same issue: https://gitlab.com/gitlab-ci-utils/docker-hugo/-/releases. You can see that v0.63.2 and prior have release evidence, but v0.64.0 and subsequent do not. This can also be seen in the raw data from the API at https://gitlab.com/api/v4/projects/10501328/releases.
What is the current bug behavior?
Release evidence is not collected.
What is the expected correct behavior?
Release evidence should be collected when release is created.
Output of checks
This bug happens on GitLab.com.
Proposed solution:
Move code related to evidence creation from the API layer(https://gitlab.com/gitlab-org/gitlab/-/blob/f79ec5e60772350abef9b494abe1f40e6dbf2cd4/lib/api/releases.rb#L70) to the service layer(https://gitlab.com/gitlab-org/gitlab/blob/master/app/services/releases/create_service.rb#L49)