Opening a design URL with spaces doesn't work
Summary
Visiting the URL of a design with spaces in its name (e.g. https://gitlab.com/gitlab-org/gitlab/issues/13490/designs/Design%20view%20with%20context.png) results in the issue description and conversation being displayed, not the design or the design tab.
URLs to designs that do not have space in their names appear to work fine.
Steps to reproduce
- Add a design with spaces in its filename and view it.
- Reload the page or copy the URL into a new tab.
Example Project
https://gitlab.com/gitlab-org/gitlab/issues/13490/designs/Design%20view%20with%20context.png
What is the current bug behavior?
- The issue is displayed with the "Discussion" tab.
- The "Designs" tab shows the number of designs, but doesn't load them when clicked:
What is the expected correct behavior?
- The issue should switch to the "Designs" tab.
- The design specified in the URL should be displayed.
Output of checks
This bug happens on GitLab.com
Possible fixes
- Ensure the Vue router can recognise this URL
- Move rapidly to designs with IIDs so that URLs such as
project_name/designs/123
can be used instead
Edited by Markus Koller