User count on admin dashboard includes disabled accounts
Summary
The number of users displayed on the Admin Dashboard includes all user accounts, including those in a disabled state. This results in an incorrect understanding of the active number of users accessing the system.
Steps to reproduce
View the admin dashboard
What is the current bug behavior?
All accounts are included in the count. This includes active and blocked users.
What is the expected correct behavior?
Only the active user count should be shown.
Results of GitLab environment info
System information System: Current User: git Using RVM: no Ruby Version: 2.3.5p376 Gem Version: 2.6.13 Bundler Version:1.13.7 Rake Version: 12.1.0 Redis Version: 3.2.5 Git Version: 2.13.6 Sidekiq Version:5.0.4 Go Version: unknown
GitLab information Version: 10.2.4 Revision: gitlab-ce@ba9acca061a977dd9c844541adfdfa0ce2165678 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql URL: https://gitlab.example.com HTTP Clone URL: https://gitlab.example.com/some-group/some-project.git SSH Clone URL: git@gitlab.example.com:some-group/some-project.git Using LDAP: no Using Omniauth: yes Omniauth Providers: github
GitLab Shell Version: 5.9.4 Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Checking GitLab Shell ...
GitLab Shell version >= 5.9.4 ? ... OK (5.9.4) Repo base directory exists? default... yes Repo storage directories are symlinks? default... no Repo paths owned by git:root, or git:git? default... yes Repo paths access is drwxrws---? default... yes hooks directories in repos are links: ... 41/1 ... ok 41/2 ... ok 41/3 ... ok 2/5 ... ok 8/6 ... ok 11/9 ... ok 11/10 ... ok 11/11 ... ok 11/12 ... ok 11/13 ... ok 11/14 ... ok 11/15 ... ok 11/16 ... ok 11/17 ... ok 11/18 ... ok 9/19 ... ok 8/21 ... ok 8/22 ... ok 8/23 ... ok 12/24 ... ok 12/25 ... ok 11/26 ... ok 13/27 ... ok 11/28 ... ok 11/29 ... ok 14/30 ... ok 11/31 ... ok 11/32 ... ok 11/33 ... ok 23/34 ... ok 11/36 ... ok 11/37 ... ok 25/38 ... ok 11/40 ... ok 11/41 ... ok 3/42 ... ok 27/43 ... ok 12/44 ... ok 20/45 ... ok 12/46 ... ok 21/47 ... ok 12/48 ... ok 11/49 ... ok 11/50 ... ok 11/51 ... ok 11/52 ... ok 12/53 ... ok 38/54 ... ok 12/55 ... ok 12/56 ... ok 14/57 ... ok 14/58 ... ok 11/59 ... ok 12/60 ... ok 11/61 ... ok 11/62 ... ok 11/63 ... ok 14/64 ... ok 11/65 ... ok 11/66 ... ok 11/67 ... ok 11/68 ... ok 11/69 ... ok 11/70 ... ok 11/71 ... ok 11/72 ... ok 11/73 ... ok 11/74 ... ok 22/76 ... ok 11/77 ... ok 18/78 ... ok 38/79 ... ok 28/80 ... ok 11/81 ... ok 27/82 ... ok 11/83 ... repository is empty 11/84 ... repository is empty 11/85 ... repository is empty 11/86 ... ok 28/87 ... ok 11/88 ... ok 11/89 ... ok 11/91 ... ok 11/93 ... ok 28/94 ... ok 11/95 ... ok 11/96 ... repository is empty 11/97 ... ok 3/98 ... ok 12/99 ... ok 11/100 ... ok 11/101 ... ok 14/102 ... ok 11/103 ... ok 11/105 ... ok 22/106 ... ok 3/107 ... repository is empty 3/108 ... ok 3/109 ... ok 12/110 ... ok 11/112 ... ok 3/113 ... ok 11/114 ... ok 3/116 ... ok 11/117 ... ok 11/118 ... ok 12/119 ... ok 11/120 ... ok 3/121 ... ok 12/122 ... ok 11/123 ... ok 11/124 ... ok 11/125 ... ok 40/126 ... ok 28/128 ... ok 27/129 ... ok 28/130 ... ok 14/131 ... ok 28/132 ... ok 7/133 ... repository is empty 8/134 ... ok 28/135 ... ok 11/136 ... ok 53/137 ... ok 41/138 ... ok 14/139 ... ok 14/140 ... ok 53/141 ... ok 53/142 ... ok 53/143 ... ok 54/144 ... ok 14/146 ... ok 14/147 ... ok 11/148 ... ok 11/149 ... ok 11/151 ... ok 11/154 ... ok 8/156 ... ok 59/158 ... repository is empty 63/159 ... ok 63/160 ... ok 63/161 ... ok 53/162 ... ok 11/163 ... ok 53/164 ... ok 63/165 ... ok 62/166 ... ok 62/167 ... ok 2/168 ... ok 62/169 ... ok 66/170 ... ok 65/172 ... ok 66/173 ... ok 60/174 ... ok 12/175 ... ok 68/176 ... ok 60/177 ... ok 53/178 ... ok 72/179 ... ok 73/180 ... ok 12/181 ... ok 73/182 ... ok 85/183 ... ok 68/184 ... ok 68/185 ... ok 68/186 ... ok 12/187 ... ok 76/189 ... repository is empty 68/190 ... ok 68/192 ... ok 78/193 ... repository is empty 79/194 ... ok 79/195 ... ok 12/196 ... ok 76/197 ... ok 72/198 ... ok 79/199 ... ok 84/200 ... ok 83/202 ... ok 28/203 ... ok 73/204 ... ok 72/205 ... ok 83/206 ... ok 87/208 ... ok 68/209 ... ok 28/211 ... ok 73/213 ... ok 54/214 ... ok 72/215 ... ok 90/216 ... ok 84/217 ... ok 84/218 ... ok 84/219 ... ok 91/220 ... ok 86/221 ... ok 92/222 ... ok 72/223 ... ok 84/224 ... ok 73/225 ... ok 73/226 ... ok 68/227 ... ok 73/228 ... ok 52/229 ... ok 68/230 ... ok 11/233 ... ok 62/234 ... ok 14/235 ... ok 79/236 ... ok 53/237 ... ok 95/238 ... ok 52/240 ... ok 96/241 ... ok 89/242 ... ok 89/243 ... ok 81/244 ... ok 97/246 ... ok 97/248 ... ok 60/249 ... ok 63/250 ... ok 23/252 ... ok 60/253 ... repository is empty 96/254 ... ok 82/255 ... ok 23/256 ... ok 72/257 ... ok 97/259 ... ok 104/260 ... ok 85/261 ... ok 14/263 ... ok 90/264 ... ok 23/265 ... ok 62/266 ... ok 72/267 ... ok 85/268 ... ok 85/270 ... ok 107/271 ... ok 83/272 ... ok 107/273 ... ok 62/274 ... ok 105/275 ... ok Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Redis available via internal API: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Reply by email is disabled in config/gitlab.yml Checking LDAP ...
LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 41/1 ... yes 41/2 ... yes 41/3 ... yes 2/5 ... yes 8/6 ... yes 11/9 ... yes 11/10 ... yes 11/11 ... yes 11/12 ... yes 11/13 ... yes 11/14 ... yes 11/15 ... yes 11/16 ... yes 11/17 ... yes 11/18 ... yes 9/19 ... yes 8/21 ... yes 8/22 ... yes 8/23 ... yes 12/24 ... yes 12/25 ... yes 11/26 ... yes 13/27 ... yes 11/28 ... yes 11/29 ... yes 14/30 ... yes 11/31 ... yes 11/32 ... yes 11/33 ... yes 23/34 ... yes 11/36 ... yes 11/37 ... yes 25/38 ... yes 11/40 ... yes 11/41 ... yes 3/42 ... yes 27/43 ... yes 12/44 ... yes 20/45 ... yes 12/46 ... yes 21/47 ... yes 12/48 ... yes 11/49 ... yes 11/50 ... yes 11/51 ... yes 11/52 ... yes 12/53 ... yes 38/54 ... yes 12/55 ... yes 12/56 ... yes 14/57 ... yes 14/58 ... yes 11/59 ... yes 12/60 ... yes 11/61 ... yes 11/62 ... yes 11/63 ... yes 14/64 ... yes 11/65 ... yes 11/66 ... yes 11/67 ... yes 11/68 ... yes 11/69 ... yes 11/70 ... yes 11/71 ... yes 11/72 ... yes 11/73 ... yes 11/74 ... yes 22/76 ... yes 11/77 ... yes 18/78 ... yes 38/79 ... yes 28/80 ... yes 11/81 ... yes 27/82 ... yes 11/83 ... yes 11/84 ... yes 11/85 ... yes 11/86 ... yes 28/87 ... yes 11/88 ... yes 11/89 ... yes 11/91 ... yes 11/93 ... yes 28/94 ... yes 11/95 ... yes 11/96 ... yes 11/97 ... yes 3/98 ... yes 12/99 ... yes 11/100 ... yes 11/101 ... yes 14/102 ... yes 11/103 ... yes 11/105 ... yes 22/106 ... yes 3/107 ... yes 3/108 ... yes 3/109 ... yes 12/110 ... yes 11/112 ... yes 3/113 ... yes 11/114 ... yes 3/116 ... yes 11/117 ... yes 11/118 ... yes 12/119 ... yes 11/120 ... yes 3/121 ... yes 12/122 ... yes 11/123 ... yes 11/124 ... yes 11/125 ... yes 40/126 ... yes 28/128 ... yes 27/129 ... yes 28/130 ... yes 14/131 ... yes 28/132 ... yes 7/133 ... yes 8/134 ... yes 28/135 ... yes 11/136 ... yes 53/137 ... yes 41/138 ... yes 14/139 ... yes 14/140 ... yes 53/141 ... yes 53/142 ... yes 53/143 ... yes 54/144 ... yes 14/146 ... yes 14/147 ... yes 11/148 ... yes 11/149 ... yes 11/151 ... yes 11/154 ... yes 8/156 ... yes 59/158 ... yes 63/159 ... yes 63/160 ... yes 63/161 ... yes 53/162 ... yes 11/163 ... yes 53/164 ... yes 63/165 ... yes 62/166 ... yes 62/167 ... yes 2/168 ... yes 62/169 ... yes 66/170 ... yes 65/172 ... yes 66/173 ... yes 60/174 ... yes 12/175 ... yes 68/176 ... yes 60/177 ... yes 53/178 ... yes 72/179 ... yes 73/180 ... yes 12/181 ... yes 73/182 ... yes 85/183 ... yes 68/184 ... yes 68/185 ... yes 68/186 ... yes 12/187 ... yes 76/189 ... yes 68/190 ... yes 68/192 ... yes 78/193 ... yes 79/194 ... yes 79/195 ... yes 12/196 ... yes 76/197 ... yes 72/198 ... yes 79/199 ... yes 84/200 ... yes 83/202 ... yes 28/203 ... yes 73/204 ... yes 72/205 ... yes 83/206 ... yes 87/208 ... yes 68/209 ... yes 28/211 ... yes 73/213 ... yes 54/214 ... yes 72/215 ... yes 90/216 ... yes 84/217 ... yes 84/218 ... yes 84/219 ... yes 91/220 ... yes 86/221 ... yes 92/222 ... yes 72/223 ... yes 84/224 ... yes 73/225 ... yes 73/226 ... yes 68/227 ... yes 73/228 ... yes 52/229 ... yes 68/230 ... yes 11/233 ... yes 62/234 ... yes 14/235 ... yes 79/236 ... yes 53/237 ... yes 95/238 ... yes 52/240 ... yes 96/241 ... yes 89/242 ... yes 89/243 ... yes 81/244 ... yes 97/246 ... yes 97/248 ... yes 60/249 ... yes 63/250 ... yes 23/252 ... yes 60/253 ... yes 96/254 ... yes 82/255 ... yes 23/256 ... yes 72/257 ... yes 97/259 ... yes 104/260 ... yes 85/261 ... yes 14/263 ... yes 90/264 ... yes 23/265 ... yes 62/266 ... yes 72/267 ... yes 85/268 ... yes 85/270 ... yes 107/271 ... yes 83/272 ... yes 107/273 ... yes 62/274 ... yes 105/275 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.3.5 ? ... yes (2.3.5) Git version >= 2.7.3 ? ... yes (2.13.6) Git user has default SSH configuration? ... yes Active users: ... 41
Checking GitLab ... Finished
Possible fixes
Not familiar with the codebase, but this seems like a straightfoward fix? (yes, I'm aware that's almost never the case)