Project Creation Using Group Template Defaults Path to Template Path
Summary
When Creating a new project from a group template (might apply to instance as well not sure), the group path defaults to the template location, not the group path that the user is viewing when they click "New Project"
Steps to reproduce
- From a group click Settings > Permissions, LFS, 2FA > Custom project templates.
- Point it to a subgroup with at least one repository.
- In the parent group, click New Project.
- On the "Blank project" page notice that the project URL is correctly set to the group path you were parked on when clicking "New Project"
- Click "Create from template"
- Pick the template repository by clicking "Use template" next to a template
- When you are placed back on the "Create from template" page, notice that the group path is now the path to the template group, not the original group you clicked "Create project" on.
- If you click create, the repository is created in the template group.
- Once the repo is created in the wrong place, on GitLab.com it takes 7 days to be removed and appears in the list of templates until removal.
What is the current bug behavior?
When template repository is selected, it updates the target path for the new repository to match the template, rather than
What is the expected correct behavior?
The repository path for the new project should not be updated to the template location when clicking "Use template"
Output of checks
This bug happens on GitLab.com
Proposed solution
(solution proposal from #208500 (comment 951165713))
When creating a project from a template mimic the behavior the new blank project just don't pre-fill the group/namespace dropdown when it is not known (see second use case in #208500 (comment 920016517)):
Before | After |
---|---|
When the user initiates the creation of a new project on a group page (see first use-case in #208500 (comment 920016517)) pre-fill the group/namespace dropdown with this group. (So that is no change to the current behavior.)
Related Tests
- Once bug has been resolved, please remove quarantine tag from
Custom group-level project templates
->from default new project path
context inee/spec/features/projects/custom_projects_template_spec.rb
and update expected results as needed to match the agreed upon solution