Deployments are not created when the url doesn't start with 'http://'
Please see gitlab-com/support-forum#2814
Summary
In gitlab CI, when using the "Environment" feature, the deployments are not created if the URL does not start with a protocol scheme.
Steps to reproduce
Create a project with a .gitlab-ci.yml file that deploys the environment. Make sure the environment url does not start with http:// or https://
Example Project
Please see the .gitlab-ci.yml file of the project BenoitAverty/10000-counter, tag 1.1.0 : https://gitlab.com/BenoitAverty/10000-counter/blob/v1.1.0/.gitlab-ci.yml and the deployment job for the review env (behavior is the same for the production env) : https://gitlab.com/BenoitAverty/10000-counter/-/jobs/44454096
What is the current bug behavior?
The deployment is not created. The environment page says "This environment has no deployments yet". The job page says "This job is creating a deployment to review/v1-1-0" even though the job finished successfully. The icon beside this message shows a exclamation mark that I interpret as a failure.
What is the expected correct behavior?
The environment should contain the deployment and the job page should link to the deployment that was created. Please see the .gitlab-ci.yml file on the same project, tag 1.1.1 : https://gitlab.com/BenoitAverty/10000-counter/blob/v1.1.2/.gitlab-ci.yml
The behavior should be the same in both cases, or at least a warning and a clear message should be provided to tell the user the format of the url to use.
Relevant logs and/or screenshots
Screenshots are available in the gitlab.com support forum : gitlab-com/support-forum#2814
Output of checks
This bug happens on gitlab.com
Possible fixes
I never made a contribution to gitlab and I am a noob with Ruby on Rails. If someone thinks this is doable and is willing to provide some guidance, I'd be happy to attempt a fix for this bug.