Warn users that milestone completion takes into account confidential issues which might not be visible to them
In !21554 (merged) we changed the logic behind milestone progress bar to always include all issues in the milestone regardless of permissions(basically it makes confidential issues included in the counters and completion percentage).
But users still won't be able to see these issues, so we want to warn them
New UX proposal
Since we need to consider performance as a key constraint for the user experience, we can consider displaying all issues in the progress bar (public + confidential), and add a new UI element that will help users but not change the logic behind the counter.
The proposal above adds a helper icon (?)
to the user interface. The static icon should be displayed on top of the progress bar. Once the user clicks the icon, a popover appears. The popover displays information about the closed items, as per gitlab's documentation, and includes a link to the docs: https://docs.gitlab.com/ee/user/project/issues/confidential_issues.html#confidential-issues
The copy in the popover should read: Some of the issues in this Release/Milestone might be confidential. These issues can be accessed only by project members who are at least reporters.
We also leave the tooltip that appears when user hovers the progress bar shows as is.
Pages this should be implemented:
- milestones list for group and project: https://gitlab.com/groups/gitlab-org/-/milestones
- individual milestone issue: https://gitlab.com/groups/gitlab-org/-/milestones/10
- releases page https://gitlab.com/gitlab-org/gitlab-runner/-/releases (after #31289 (closed) is implemented)
- individual release page when it will finished
The following discussion from !21554 (merged) should be addressed:
-
@oswaldo started a discussion: (+13 comments) I'd like to understand a bit better where it's used today. If there are only private issues (which is unlikely), we'd show
0
as a counter?My concern is that this should impact the completion percentage and others, which might be perceived as a bug to end users? Should that be documented somewhere in the UI?