Dependencies Validator should check job statues
Description
Currently, Dependencies Validator is checking the following conditions.
- Is depended job's artifact expired?
- Is depended job's artifact erased?
And we tried to implement checking the status as well. https://gitlab.com/gitlab-org/gitlab-ce/issues/34834
- Is depended job's status completed?
But this introduced this problem https://gitlab.com/gitlab-org/gitlab-ce/issues/41110, so we reverted the change.
@ayufan said at https://gitlab.com/gitlab-org/gitlab-ce/issues/41110#note_51384473
Argh. This is confusing. As it means that we cannot properly validate dependencies, because of manual jobs > which are simply conditional.>
It means that the proper way for handle manual jobs is explicitness of dependencies vs implicitness.
So, we should validate manual job only if it is explicitly listed as dependency. If it is defined implicitly (> dependencies not defined) we should skip manual.
This is true.