Dependencies Validator fails when depended job is `manual`
Summary
Reported at https://gitlab.com/gitlab-org/gitlab-ce/issues/41021#note_51364173.
I see an issue:
irb(main):042:0> build.dependencies[0].complete?
=> false
irb(main):043:0> build.dependencies[0].status
=> "manual"
https://gitlab.com/gitlab-org/gitlab-ee/blob/master/app/models/concerns/has_status.rb#L104 shows that COMPLETED_STATUSES
doesn't include manual
.
Steps
-
Apply a new patch as manual
jobs do not fail Dependencies Validator -
We disable ci_disable_validates_dependencies
on dev.gitlab.org again (i.e. Enable Dependencies Validator again)
What is the current bug behavior?
If a job has manual
depended job, it fails
What is the expected correct behavior?
If a job has manual
depended job, it should not fail
/cc @ayufan @stanhu @bikebilly
Edited by Shinya Maeda