Clarify the difference in process between personal preference suggestions and requirements
The following discussion from !23966 (merged) should be addressed:
-
@m_gill started a discussion: (+3 comments) I think this is a great change. There are 2 things I want to mention on both sides of the coin:
- Sometimes the back and forth defeats the purpose of iteration. I have seen fairly simple MRs, version 1 of something, go through multiple rounds (30+ days of review) at which point there would've been time for a version 2.
- Sometimes that "personal preference" is really the reviewer requiring you to do it. I've seen this in cases that make sense, or at least in cases that I agree with, but nevertheless - if there's no documentation or agreement to support your personal preference, it really just is personal preference. In cases like this, the discussion should be happening in a new MR.