Hide file header buttons in merge requests
Context
We looked at the tracking data in 4 milestones after #197412 (closed) was shipped, to understand the usage of the following buttons in the merge request file header:
- Copy file path
- Toggle comments for this file
- Edit file
- Show full file
- View file @ SHA
- Review app link
Proposal
Based on the data that we collected, we've decided to hide almost all of these buttons, by moving them into a specific dropdown.
State | Image |
---|---|
Resting | ![]() |
Resting - Review app | ![]() |
Hover | ![]() |
Menu open | ![]() |
The Review app
button is kept outside the dropdown because the following assumptions:
- Using a review app can sometimes be a better way to review changes than looking at the text changes alone. If we moved this to the dropdown, we're afraid that its usefulness and discovery would drop significantly.
- Related to the above, we don't think we have reliable data to make a good decision, since the numbers we collected look at all MRs and not just MRs where a review app is available.
Edited by Pedro Moreira da Silva