Allow to make "Start discussion" the default
Description
When doing reviews on merge requests, my main use case is to create a discussion, so that people can reply to my comments in an orderly fashion.
However, the default for submitting the comment is is creating a comment instead of a discussion. So I've found myself more than once deleting a comment I just created and replacing it with a discussion that has the same content.
Creating a simple comment is the special case for me, not the common case.
Proposal
- Remove dual button switcher to either "Comment" or "Start A Discussion" with a single button that says "Comment"
- For new top level comments, include a "Make Resolvable?" checkbox that is selected by default.
- This checkbox and be unchecked or checked at any time. If checked, it is added to the count of comments that need to be resolved before an MR can be merged.
- Always display a "reply" box beneath a top level comment or last reply on a discussion.
- When replying to a comment, the button to submit the reply should be "Reply"
Links / references
https://gitlab.com/gitlab-org/gitlab-ce/issues/30299 is close to solving my use case, too, because it allows people to still orderly reply to an "unordered" comment. However, I would still be missing out on requiring the discussion to be resolved :(
Documentation blurb
Overview
What is it? Why should someone use this feature? What is the underlying (business) problem? How do you use this feature?
Use cases
Who is this for? Provide one or more use cases.
Feature checklist
Make sure these are completed before closing the issue, with a link to the relevant commit.
-
Feature assurance -
Documentation -
Added to features.yml