gitlab.rb's external_url is set to hostname during upgrade
Summary
- external_url is set to hostname during upgrade
- We upgraded to 12.7.0 this morning and suddenly several links pointed to a different hostname than the one we configured our instance to
Steps to reproduce
- 12.6.4
- Upgrade to 12.7.0.
What is the current bug behavior?
- /etc/gitlab/gitlab.rb has an entry external_url with the hostnme
What is the expected correct behavior?
- /etc/gitlab/gitlab.rb keeps the previously configured external_url
Relevant logs and/or screenshots
You can see the Browser URL and the linked url at the footer differ:
Also emails do not use the correct links:
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Ubuntu 16.04 Proxy: no Current User: git Using RVM: no Ruby Version: 2.6.5p114 Gem Version: 2.7.10 Bundler Version:1.17.3 Rake Version: 12.3.3 Redis Version: 5.0.7 Git Version: 2.24.1 Sidekiq Version:5.2.7 Go Version: unknown
GitLab information Version: 12.7.0-ee Revision: c6ca82f7978 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: PostgreSQL DB Version: 9.6.11 URL: http://ec2-3-122-59-92.eu-central-1.compute.amazonaws.com HTTP Clone URL: http://ec2-3-122-59-92.eu-central-1.compute.amazonaws.com/some-group/some-project.git SSH Clone URL: git@ec2-3-122-59-92.eu-central-1.compute.amazonaws.com:some-group/some-project.git Elasticsearch: no Geo: no Using LDAP: no Using Omniauth: yes Omniauth Providers: google_oauth2
GitLab Shell Version: 11.0.0 Repository storage paths:
- default: /gitlab-data/git-data/repositories GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab subtasks ...Checking GitLab Shell ...
GitLab Shell: ... GitLab Shell version >= 11.0.0 ? ... OK (11.0.0) Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Internal API available: OK Redis available via internal API: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Gitaly ...
Gitaly: ... default ... OK
Checking Gitaly ... Finished
Checking Sidekiq ...
Sidekiq: ... Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Incoming Email ...
Incoming Email: ... Checking Reply by email ...
IMAP server credentials are correct? ... yes Init.d configured correctly? ... skipped MailRoom running? ... skipped
Checking Reply by email ... Finished
Checking Incoming Email ... Finished
Checking LDAP ...
LDAP: ... LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab App ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 1238/5 ... yes 1223/7 ... yes 35/10 ... yes 1217/12 ... yes 13/13 ... yes 8/14 ... yes 14/15 ... yes […] 1238/3230 ... yes 1891/3231 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.5.3 ? ... yes (2.6.5) Git version >= 2.22.0 ? ... yes (2.24.1) Git user has default SSH configuration? ... yes Active users: ... 92 Is authorized keys file accessible? ... skipped (authorized keys not enabled) Elasticsearch version 5.6 - 6.x? ... skipped (elasticsearch is disabled)
Checking GitLab App ... Finished
Checking GitLab subtasks ... Finished
Possible fixes
- Changing the gitlab.rb manually to restored our wanted value fixed it but during the upgrade process the config must have been changed somehow