"Deploy in progress" page should respond HTTP 503
Summary
the "Deploy in progress" page responds responds HTTP 200 OK
Steps to reproduce
visit gitlab.com during 1 of thse deployment phases
What is the current bug behavior?
returns HTTP/1.1 200 OK
What is the expected correct behavior?
should return HTTP/1.1 503 Service Unavailable
and because the page says Please try again in a few minutes
, it should probably also include
the Retry-After
-header, perhaps Retry-After: 600
(which will make the browser try to refresh the page after 10 minutes, aka 600 seconds)
in RFC 2616, HTTP 503 is described as
The server is currently unable to handle the request due to a temporary overloading or maintenance of the server. The implication is that this is a temporary condition which will be alleviated after some delay. If known, the length of the delay MAY be indicated in a Retry-After header.
Relevant logs and/or screenshots
https://i.imgur.com/P2JtAYU.png
Output of checks
This bug happens on GitLab.com