Server URL configuration change
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
Description
The issue is that there are currently two different (potentially opposing) methods to get the sites url internally within GitLab, {root_url} and {@project.web_url}.
{root_url} returns the URL that the user accessed the page by ... and {@project.web_url} uses the host defined in GitLab.yml
{root_url} will not work in some http reverse proxy cases and {@project.web_url} will not work either in other cases (isolated networks).
There are several image links that use the full domain name, the git clone path etc that will need to be changed.
Proposal
I think that the best way to handle this would be to have the option in the GitLab.yml for the host (that is already there), but default it to blank. If the host setting is filled in then use that location else use the {root_url}.
Links / references
The original issue is at https://gitlab.com/gitlab-org/gitlab-ce/issues/22124 And it was sugguested by @winniehell that I post a feature proposal.