Show warning for user actions that potentially slows down merge trains
Problem 1
During the dogfoooding on www-gitlab-com, we realized that there was a quite number of users who chose "Immediate Merge".
This is basically a discouraged action as described in here. This button should be clicked in only necessary situation such as a immediate patch, and should not be clicked in general because it requires train reconstructions, thus users have to wait for long time to see their MRs reflected to https://docs.gitlab.com/.
We should show a warning modal or something when user tries to proceed the "Merge Immediately" button, that the action could result in annoying the entire project.
UX Proposal
As a user, I want to bypass the merge train and merge immediately, so that I can merge a high-priority merge request (e.g. critical patch)
Acceptance criteria
- Show a warning dialog when user tries to "Merge Immediately", as it pushes the other positions back thus the author feels the MR train is slow.
- Once the user selects the
Merge immediately
, a modal is triggered. The modal should read:
Merge immediately |
---|
Merging immediately isn't recommended as it may cause a relevant negative impact on the existing merge train. Read the documentation for more information. Are you sure you want to merge immediately? |
Cancel - Merge immediately |
- The merge immediately button should be red/danger type.
- Clicking cancel closes the modal and no action is taken by the system.
- Clicking merge immediately closes the modal. The MR changes get merged into the target branch. It regenerates the merge train. It pushes the other mr positions back thus the author feels the MR train is slow.
- The modal should meet Pajamas guidelines https://design.gitlab.com/usability/error-prevention/#high-severity
Edited by Rayana Verissimo