BUG: Prevent approval of merge requests by merge request author
Summary
With Prevent approval of merge requests by merge request author enabled, a user is still served with an Approval of the MR they have authored when Merge Request Approvers (other than the author or none at all) have been created within the project settings.
Steps to reproduce
- Within a project on GitLab.com, check "Prevent approval of merge requests by merge request author" within Project Settings>General>Merge request approvals
- In the same settings section, do not add any approvers.
- Create a merge request
- Receive an "Approve" button with a light grey message, "No approval required; you can still approve"
What is the current bug behavior?
The MR author is served an "Approve" button
What is the expected correct behavior?
The MR author should not be offered an "Approve" button regardless of whether MR approvers are explicitly added to the project settings.