Follow-up from "EE: Split `.gitlab-ci.yml` into multiple includes"

The following discussions from !10854 (merged) should be addressed:

• @rymai started a discussion:

  Extra blank line.

• @rymai started a discussion:

  I think naming this file setup is misleading as I would expect jobs in this file to be for the "setup"/"prepare" stage.

  Here the jobs run in the test stage and are mostly safeguards, so maybe calling this file safeguard.gitlab-ci.yml would make sense?

• @rymai started a discussion: (+1 comment)

  What do you think of extracting the following lines to a separate file? e.g. .gitlab/ci/ee-test-metadata.gitlab-ci.yml and add an EE-specific line in .gitlab-ci.yml?

• @rymai started a discussion:

  I think we want to have a new line at the end of the file.

• @rymai started a discussion: (+1 comment)

  Based on https://docs.gitlab.com/ee/ci/yaml/#environmentaction I think this job should be in the same stage as its corresponding deploy job (which can be review-docs-deploy-manual or review-docs-deploy).

  I think we could move all three jobs to the build stage, WDYT?

• @rymai started a discussion:

  I think that would make sense to move it out to a dedicated .gitlab/ci/quality.gitlab-ci.yml file?

• @rymai started a discussion:

  I think that would make sense to move it out to a dedicated .gitlab/ci/quality.gitlab-ci.yml file?

• @rymai started a discussion:

  WDYT of moving all the db:*, migration:*, gitlab:setup-pg and gitlab:setup-mysql jobs into a new db-gitlab-ci.yml file?

• @rymai started a discussion:

  WDYT of moving this out of this file since it's in the post-test stage and it's not running tests?

• @rymai started a discussion:

  WDYT of moving this to a dedicated EE-specific file and add an EE-specific line in .gitlab-ci.yml?

• @rymai started a discussion:

  We should move that directly before the migration:upgrade-pg-ce-to-ee job below.

• @rymai started a discussion:

  If we extract the db jobs and the EE-specific jobs from this file, we should probably rename it to .gitlab/ci/rspec.gitlab-ci.yml to clarify its content.

• @rymai started a discussion:

  Should this be .gitlab/ci/security.gitlab-ci.yml instead?

• @rymai started a discussion:

  Should this be moved to a dedicated .gitlab/ci/quality.gitlab-ci.yml file?

• @rymai started a discussion:

  I think that would make sense to move it out to a dedicated .gitlab/ci/quality.gitlab-ci.yml file?

• @rymai started a discussion:

  WDYT of nesting this job under .gitlab/ci/prepare/rspec.gitlab-ci.yml so that have a split by stage, then by type of jobs?

• @rymai started a discussion:

  WDYT of moving that just before gitlab:setup-pg?

• @rymai started a discussion:

  Same here, this could be moved to .gitlab/ci/prepare/review.gitlab-ci.yml?

• @rymai started a discussion:

  I think that would make sense to move it out to a dedicated .gitlab/ci/quality.gitlab-ci.yml file?

• @rymai started a discussion:

  I think that would make sense to move it out to a dedicated .gitlab/ci/quality.gitlab-ci.yml file?